-
- Notifications
You must be signed in to change notification settings - Fork 19.3k
BUG: parse_dates=False while passing date_parser tries to use date parser #44599
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from 6 commits
Commits
Show all changes
8 commits Select commit Hold shift + click to select a range
cbbf7c1 BUG: Providing fix for GH#44366
loicdiridollou 84f8f63 BUG: fix pre-commit run
loicdiridollou 4776854 BUG: adding other API changes for change of default argument
loicdiridollou c5eec17 Rewriting if statement and adding test
loicdiridollou 465a6f1 BUG: changing pd.Series to Series to validate pre-commit hook
loicdiridollou 3205754 Removing the second whatsnew statement only to keep the bug fix one
loicdiridollou a69094b BUG: simplifying the test with parser and parse_dates False #44366
loicdiridollou 56e68cf BUG: fixing pre-commit #44366
loicdiridollou File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can we reduce number of columns and use small ints? This is really hard to read
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You are right, this should be better now. I was just reusing the data from
test_read_csv_with_custom_date_parser(which could also be simplified at a later stage)