BUG: parse_dates=False while passing date_parser tries to use date parser #44599
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
loicdiridollou changed the title 
phofl requested changes Nov 24, 2021
pandas/io/parsers/readers.py Outdated
| filepath_or_buffer: FilePath | ReadCsvBuffer[bytes] | ReadCsvBuffer[str], kwds | ||
| ): | ||
| """Generic reader of line files.""" | ||
| if kwds.get("date_parser", None) is not None: |
There was a problem hiding this comment.
This is hard to read. Please do it somehow like this:
if kwds.get("date_parser", None) is not None and kwds.get("pars_dates", None) is None: kwds.get["pars_dates"] = True elif kwds.get("pars_dates", None) is None: kwds.get["pars_dates"] = False There was a problem hiding this comment.
Correct! I have made the changes so now it is more readable, added a test to see if the parser is not called when we set parse_dates to False.
Some tests are failing for an obscure reason as they are not related to the code change (and they are also failing on other builds)
phofl reviewed Nov 24, 2021
| | ||
| testdata = StringIO( | ||
| """time e n h | ||
| 41047.00 -98573.7297 871458.0640 389.0089 |
There was a problem hiding this comment.
Can we reduce number of columns and use small ints? This is really hard to read
There was a problem hiding this comment.
You are right, this should be better now. I was just reusing the data from test_read_csv_with_custom_date_parser (which could also be simplified at a later stage)
phofl approved these changes Nov 25, 2021
| thx @loicdiridollou |
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
I have updated the code in the
pandas/io/parsers/readers.pysince if we pasedparse_dates=False, it would still change it to True.