Skip to content

REF: IntervalIndex.intersection match pattern in other intersection methods #38190

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Dec 2, 2020
Merged

REF: IntervalIndex.intersection match pattern in other intersection methods #38190

merged 4 commits into from
Dec 2, 2020

Conversation

@jbrockmendel
Copy link
Member

@jbrockmendel jbrockmendel commented Nov 30, 2020

Looking to share the boilerplate and have subclasses just implement _intersection.
@jbrockmendel
Copy link
Member Author

jbrockmendel commented Dec 1, 2020

@jreback between @phofl and me there's a handful of FooIndex.intersection PRs that are becoming blockers: #38190, #38111, #38197, #38154, #38196 (and #38105 will allow for more de-duplication and fastpaths)
@jreback
Copy link
Contributor

jreback commented Dec 1, 2020

kk will look soon

can i indicate which are orthogonal? or any ordering here?
@jbrockmendel
Copy link
Member Author

jbrockmendel commented Dec 1, 2020

or any ordering here?

Current plan in #38197 is to share the whatsnew note with #38111, but otherwise these should be all independent.

These should be all logically orthogonal, but the ones least likely to involve merge conflicts are #38105 and #38154.
@phofl phofl mentioned this pull request Dec 1, 2020
Merged
3 tasks
@jreback jreback added Refactor Internal refactoring of code Interval Interval data type labels Dec 2, 2020
@jreback jreback added this to the 1.2 milestone Dec 2, 2020
@jreback jreback merged commit aed5dba into pandas-dev:master Dec 2, 2020
@jbrockmendel jbrockmendel deleted the ref-setops-44 branch December 2, 2020 01:48
@jreback
Copy link
Contributor

jreback commented Dec 2, 2020

I think all are merged (except one needs a rebase),
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Interval Interval data type Refactor Internal refactoring of code

2 participants

@jbrockmendel @jreback