Skip to content

Conversation

@jbrockmendel
Copy link
Member

@jbrockmendel jbrockmendel commented Nov 30, 2020

  • closes #xxxx
  • tests added / passed
  • passes black pandas
  • passes git diff upstream/master -u -- "*.py" | flake8 --diff
  • whatsnew entry
@jbrockmendel
Copy link
Member Author

after #38111 will update the whatsnew from there to include this

@jbrockmendel
Copy link
Member Author

@jreback did something break the npdev build again while i wasnt looking?

@jreback
Copy link
Contributor

jreback commented Dec 1, 2020

i wonder if this is the backport of the 2d indexing message (just merged to 1.1.5)

@jbrockmendel
Copy link
Member Author

yah its just a complaint about a mismatched exception message in the 2d indexing case

@jreback jreback added the Refactor Internal refactoring of code label Dec 2, 2020
@jreback jreback added this to the 1.2 milestone Dec 2, 2020
@jreback
Copy link
Contributor

jreback commented Dec 2, 2020

can you rebase (and update the fixture name)

@jbrockmendel
Copy link
Member Author

rebased with whatsnew

@jreback
Copy link
Contributor

jreback commented Dec 2, 2020

looks fine. waiting on CI.

@jbrockmendel
Copy link
Member Author

greenish

@simonjayhawkins
Copy link
Member

re-run and green

@jreback jreback merged commit dffab1f into pandas-dev:master Dec 2, 2020
@jbrockmendel jbrockmendel deleted the bug-ri-intersection branch December 2, 2020 14:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Refactor Internal refactoring of code

3 participants