Skip to content

Fix type of UnionField to accept not only Field but also Serializer #95

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 14, 2025
Merged

Fix type of UnionField to accept not only Field but also Serializer #95

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions rest_framework_dataclasses/fields.py
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
import collections.abc
from typing import Any, Dict, Generic, Type, TypeVar, Union, Optional
from typing import Any, Dict, Generic, Mapping, Type, TypeVar, Union, Optional

from django.core.exceptions import ImproperlyConfigured
from rest_framework.exceptions import ValidationError
Expand Down Expand Up @@ -80,7 +80,7 @@ class UnionField(Field, Generic[T]):
type_mapping: Dict[type, str]

def __init__(self,
child_fields: Dict[type, Union[Field, Type[Field]]],
child_fields: Mapping[type, Union[Field, Type[Field]]],
*,
nest_value: bool = False,
discriminator_field_name: Optional[str] = None,
Expand Down