Fix type of UnionField to accept not only Field but also Serializer #95
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
Hello, thanks for your maintenance.
I fixed the constructor type of
UnionFieldto accept not onlyFieldbut also subclass ofField, such asSerializer.As described in Common issues and solutions / variance in mypy document,
Dict[T, U]type does not accept subclass ofU, whileMappingdoes. So I replace Dict with Mapping.Example
The code below causes error by mypy. After applying this PR, it does NOT causes any error.