- Notifications
You must be signed in to change notification settings - Fork 32
chore: upgrade min OS from 9 to 10 #284
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Changes from 4 commits
Commits
Show all changes
6 commits Select commit Hold shift + click to select a range
d30b727 upgrade min OS from 9 to 10
jaeopt 31569d6 more changes to upgrade min OS to 10.0
jaeopt 1e9728f clean up code for iOS9.0
jaeopt 7272e16 change travis unit test from iOS9.3 to 11.1
jaeopt b8fba32 change a comment
jaeopt 0a989e9 Merge branch 'master' into jae/minOS
jaeopt File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,16 +1,16 @@ | ||
| PODS: | ||
| - SwiftLint (0.34.0) | ||
| - SwiftLint (0.38.2) | ||
| | ||
| DEPENDENCIES: | ||
| - SwiftLint | ||
| | ||
| SPEC REPOS: | ||
| https://github.com/CocoaPods/Specs.git: | ||
| trunk: | ||
| - SwiftLint | ||
| | ||
| SPEC CHECKSUMS: | ||
| SwiftLint: 79d48a17c6565dc286c37efb8322c7b450f95c67 | ||
| SwiftLint: 8f5d2f903e1c9bcbc832fd16771e80a263ac6cbb | ||
| | ||
| PODFILE CHECKSUM: 94877e134bcac3007b5b3e8cdbd17fa6eb0fd375 | ||
| PODFILE CHECKSUM: 159491f53ea704c30be049e048d854a49f9b7433 | ||
| | ||
| COCOAPODS: 1.8.0 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| | @@ -41,26 +41,20 @@ open class DefaultLogger: OPTLogger { | |
| return | ||
| } | ||
| | ||
| if #available(iOS 10.0, tvOS 10.0, *) { | ||
| var osLogType: OSLogType | ||
| | ||
| switch level { | ||
| case .error: osLogType = .error | ||
| case .info: osLogType = .info | ||
| case .debug: osLogType = .debug | ||
| default: osLogType = .default | ||
| } | ||
| | ||
| os_log("[%{public}@] %{public}@", log: .optimizely, type: osLogType, level.name, message) | ||
| osLogUsed = true | ||
| } else { | ||
| let message = "[OPTIMIZELY][" + level.name + "] " + message | ||
| NSLog(message) | ||
| var osLogType: OSLogType | ||
| Contributor There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. header. | ||
| | ||
| switch level { | ||
| case .error: osLogType = .error | ||
| case .info: osLogType = .info | ||
| case .debug: osLogType = .debug | ||
| default: osLogType = .default | ||
| } | ||
| | ||
| os_log("[%{public}@] %{public}@", log: .optimizely, type: osLogType, level.name, message) | ||
| osLogUsed = true | ||
| } | ||
| } | ||
| | ||
| @available(iOS 10.0, tvOS 10.0, *) | ||
| extension OSLog { | ||
| static let optimizely = OSLog(subsystem: "com.optimizely.swift-sdk", category: "OPTIMIZELY") | ||
| } | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
please update header.