chore: upgrade min OS from 9 to 10 #284
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
| func startTimer() { | ||
| // timer is activated only for iOS10+ and non-zero interval value | ||
| guard #available(iOS 10.0, tvOS 10.0, *), timerInterval > 0 else { | ||
| guard timerInterval > 0 else { |
Contributor
There was a problem hiding this comment.
please update header.
| } else { | ||
| let message = "[OPTIMIZELY][" + level.name + "] " + message | ||
| NSLog(message) | ||
| var osLogType: OSLogType |
msohailhussain previously approved these changes Jan 15, 2020
Contributor
msohailhussain left a comment
msohailhussain left a comment There was a problem hiding this comment.
lgtm once headers are updated.
thomaszurkan-optimizely approved these changes Jan 15, 2020
Contributor
thomaszurkan-optimizely left a comment
thomaszurkan-optimizely left a comment There was a problem hiding this comment.
LGTM. As Sohail mentioned. Update the header. :)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
Since iOS13 introduced, it can be a good time to drop support for the old iOS version.
Also Travis stop supporting iOS9 for xcode10.3 and xcode11+, so no way for CI testing anyway.
[JIRA-5629]