Basebutton tooltip params #1402
Conversation
| Use Run test server using develop.opencast.org as backend: Specify a different backend like stable.opencast.org: It may take a few seconds for the interface to spin up. |
priya-tik force-pushed the basebutton-tooltip-params branch from 5ce319c to 3aece8c Compare 
There was a problem hiding this comment.
Can confirm that this fixes the issue, thanks for that! Since the bug is already occurring in r/17.x, could you rebase your branch onto r/17.x and point the PR against it instead of develop? (Since very recently we now have the same versioning in the admin interface as we have in Opencast. r/17.x is the oldest and we forward merge our versions, so if it goes into r/17.x it will go into all versions.)
| <Tooltip title={tooltipParams ? t(tooltipText) : t(tooltipText, tooltipParams)}> | ||
| {buttonComponent} | ||
| <Tooltip title={tooltipParams ? t(tooltipText, tooltipParams) : t(tooltipText)}> | ||
| {buttonComponent} |
There was a problem hiding this comment.
This looks like an accidental removal to me?
There was a problem hiding this comment.
This wasn’t accidental. I updated the expression to tooltipParams ? t(tooltipText, tooltipParams) : t(tooltipText) because the previous version caused an error. The change ensures that tooltipParams are passed to t() only when they exist, otherwise it falls back to the plain translation string.
There was a problem hiding this comment.
I see know that the line I marked did not all make clear what I wanted to refer to. I am very sorry for the confusion, of course updating the expression as you did makes perfect sense. I was only referring to the removal of the tab character ^^`.
This PR fixes an issue where tooltipParams were ignored when rendering the tooltip in BaseButton.
Previously, placeholders like {{filterName}} in translations were not being replaced even when tooltipParams was provided.