Skip to content

#34 support bean validation #71

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 17 commits into from
Jan 23, 2020
Merged

#34 support bean validation #71

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
17 commits
Select commit Hold shift + click to select a range
86963dd
#34 add .gradle to ignore file
Jan 11, 2020
7a62203
#34 add beanValidation option
Jan 11, 2020
085928f
#34 extend base test for bean-validation
Jan 16, 2020
a2d378f
#34 add test case for bean validation
Jan 16, 2020
4b74d49
#34 fix test case
Jan 16, 2020
63f2ef4
Merge remote-tracking branch 'upstream/master' into #34-Support-bean-…
Jan 19, 2020
3a58acb
#34 add first implementation for bean-validation
Jan 19, 2020
20a2d17
#34 fix unit tests
Jan 21, 2020
11eb969
#34 change beanvalidation option in integration test
Jan 21, 2020
d13747a
#34 fix title
Jan 21, 2020
1a4bda1
#34 rename
Jan 21, 2020
8d79100
Merge remote-tracking branch 'upstream/master' into #34-Support-bean-…
Jan 21, 2020
37be156
#34 move beanValidation outside of withAnnotation
Jan 21, 2020
64076b7
#34 move to collectImports
Jan 21, 2020
25d4016
#34 extract method
Jan 21, 2020
bc21a99
#34 create unit tests
Jan 21, 2020
db537f1
small cleanup
hauner Jan 23, 2020
File filter

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
#34 move beanValidation outside of withAnnotation
  • Loading branch information
Bastian Wilhelm committed Jan 21, 2020
commit 37be156d9bb946029df279e1e0fa60f536449160
8 changes: 4 additions & 4 deletions src/main/groovy/com/github/hauner/openapi/spring/writer/InterfaceWriter.groovy
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -61,12 +61,12 @@ class InterfaceWriter {
imports.add (ep.method.classNameWithPackage)

ep.parameters.each { p ->
if (apiOptions.beanValidation) {
imports.addAll(beanValidationWriter.collectImports (p.dataType))
}

if (p.withAnnotation()) {
imports.add (p.annotationWithPackage)

if (apiOptions.beanValidation) {
imports.addAll(beanValidationWriter.collectImports (p.dataType))
}
}

imports.addAll (p.dataTypeImports)
Expand Down
8 changes: 4 additions & 4 deletions src/main/groovy/com/github/hauner/openapi/spring/writer/MethodWriter.groovy
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -107,11 +107,11 @@ class MethodWriter {

def methodDefinition = ''

if (it.withAnnotation ()) {
if(apiOptions.beanValidation){
methodDefinition += " ${beanValidationWriter.createAnnotations(it.dataType)}"
}
if(apiOptions.beanValidation){
methodDefinition += " ${beanValidationWriter.createAnnotations(it.dataType)}"
}

if (it.withAnnotation ()) {
methodDefinition += " ${createParameterAnnotation (it)}"
}

Expand Down