Skip to content

#34 support bean validation #71

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 17 commits into from
Jan 23, 2020
Merged

#34 support bean validation #71

merged 17 commits into from
Jan 23, 2020

Conversation

schlagi123
Copy link

Hi Martin,

this is a first implementation that can use basic functions of bean-validation
hauner
hauner requested changes Jan 20, 2020
View reviewed changes
Copy link
Member

@hauner hauner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi,
that looks simpler and cleaner than I thought it would look like 👍 I have added a few comments to the code.

Apart from that:

  • I see a couple of test failing
  • I'm missing some unit test :-)

otherwise well done!
@schlagi123 schlagi123 requested a review from hauner January 21, 2020 16:38
@hauner hauner merged commit dd38424 into openapi-processor:master Jan 23, 2020
@schlagi123 schlagi123 deleted the #34-Support-bean-validation branch January 25, 2020 11:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

2 participants

@schlagi123 @hauner