Clarify boundaries of numeric env vars #4331
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
dashpole approved these changes Dec 10, 2024
reyang reviewed Dec 10, 2024
reyang reviewed Dec 10, 2024
Member
| Need a changelog entry. |
pellared reviewed Dec 10, 2024
carlosalberto added a commit that referenced this pull request Dec 21, 2024
Related to #4283. A [comment](#4331 (comment)) adding a "type" column to each env var, but didn't feel appropriate to extend scope of #4331. --------- Co-authored-by: Carlos Alberto Cortez <calberto.cortez@gmail.com> Co-authored-by: Reiley Yang <reyang@microsoft.com>
| This PR was marked stale due to lack of activity. It will be closed in 7 days. |
reyang approved these changes Jan 6, 2025
trask reviewed Jan 6, 2025
trask approved these changes Jan 6, 2025
Member
trask left a comment
trask left a comment There was a problem hiding this comment.
A couple of non-blocking comments above
carlosalberto approved these changes Jan 7, 2025
jsuereth approved these changes Jan 7, 2025
Member Author
pellared reviewed Jan 14, 2025
…ck-berg/opentelemetry-specification into clarify-number-env-var-bounds
pellared approved these changes Jan 15, 2025
This was referenced Jan 15, 2025
Merged
carlosalberto added a commit that referenced this pull request Jan 22, 2025
### Logs - Remove the deprecated Events API and SDK in favor of having Events support in the Logs API and SDK. ([#4353](#4353)) - Remove `Logger`'s Log Instrumentation operations. ([#4352](#4352)) - Make all `Logger` operations user-facing. ([#4352](#4352)) ### SDK Configuration - Clarify that implementations should interpret timeout environment variable values of zero as no limit (infinity). ([#4331](#4331))
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
8 participants
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
Resolves #4283.
OTEL_ATTRIBUTE_*/OTEL_SPAN_ATTRIBUTE_*/OTEL_LOGRECORD_ATTRIBUTE_*,OTEL_BSP_MAX_QUEUE_SIZE,OTEL_BLRP_MAX_QUEUE_SIZE.Related PR to
opentelemetry-configuration: open-telemetry/opentelemetry-configuration#151