-
Couldn't load subscription status.
- Fork 912
Closed
Labels
Feature RequestSuggest an idea for this projectSuggest an idea for this projectgood first issuehelp wanted
Description
Working on #7023 to implement spec PR open-telemetry/opentelemetry-specification#4331, I realized other parts of our implementation are not aligned with the spec:
- SpanLimitsBuilder /
LogLimitsBuilderenforce that all the values are positive, when the spec (rightly) says that 0 is an acceptable value.LogLimitsBuilderhas the same issues. - BatchSpanProcessorBuilder /
BatchLogRecordProcessorBuilderdon't enforce any limits around max queue size. This means its possible to set the queue size to zero or a negative value, which is not allowed in the spec. Not sure what the underlying queue implementations do with a zero or negative value, but we add checks for this. Also, the max export size must be less than or equal to the max queue size.
Metadata
Metadata
Assignees
Labels
Feature RequestSuggest an idea for this projectSuggest an idea for this projectgood first issuehelp wanted