Skip to content

feat!: update minimum supported PHP version to 8.1 #109

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 10 commits into
base: main
Choose a base branch
from
Draft

feat!: update minimum supported PHP version to 8.1 #109

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
10 commits
Select commit Hold shift + click to select a range
9e63abd
feat: nix support with direnv and updated README
tcarrio Nov 30, 2023
9ebc58c
chore: bump PHP version in .tool-versions
tcarrio Nov 30, 2023
e725139
chore: FIXUP for direnv and nix commit
tcarrio Nov 30, 2023
ab59e38
chore: upgrade min version supported to PHP 8.1
tcarrio Nov 30, 2023
5cb8e47
refactor: array unpacking native enums and constructor promotion and …
tcarrio Nov 30, 2023
a80fdb1
fix: phpstan issues
tcarrio Nov 30, 2023
731393b
refactor: static analysis updates and plenty of enum changes
tcarrio Nov 30, 2023
ff047aa
ci: update min PHP version to 8.1
tcarrio Dec 4, 2023
09dbb02
fix: updates to support 8.1 and errors
tcarrio Dec 4, 2023
21be2ee
test: add test for missing keys
tcarrio Dec 4, 2023
File filter

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
fix: phpstan issues 
Signed-off-by: Tom Carrio <tom@carrio.dev>
  • Loading branch information
@tcarrio
tcarrio committed Dec 4, 2023
commit a80fdb18a976c791e3ff84c035deb70dac70be6a
2 changes: 1 addition & 1 deletion src/implementation/flags/EvaluationContext.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,7 @@ class EvaluationContext implements EvaluationContextInterface

public function __construct(
private ?string $targetingKey = null,
protected ?AttributesInterface $attributes = new Attributes(),
protected readonly AttributesInterface $attributes = new Attributes(),
) {
}

Expand Down
1 change: 0 additions & 1 deletion src/implementation/hooks/HookHints.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,7 +17,6 @@ class HookHints implements HookHintsInterface
*/
public function __construct(private readonly array $hints = [])
{
$this->hints = $hints;
}

/**
Expand Down