feat!: update minimum supported PHP version to 8.1 #109
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
tcarrio changed the title 
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@ ## main #109 +/- ## ============================================ + Coverage 95.19% 95.89% +0.69% + Complexity 227 220 -7 ============================================ Files 40 40 Lines 583 584 +1 ============================================ + Hits 555 560 +5 + Misses 28 24 -4 ☔ View full report in Codecov by Sentry. |
Signed-off-by: Tom Carrio <tom@carrio.dev>
Signed-off-by: Tom Carrio <tom@carrio.dev>
Signed-off-by: Tom Carrio <tom@carrio.dev>
Signed-off-by: Tom Carrio <tom@carrio.dev>
…readonly properties Signed-off-by: Tom Carrio <tom@carrio.dev>
Signed-off-by: Tom Carrio <tom@carrio.dev>
Signed-off-by: Tom Carrio <tom@carrio.dev>
Signed-off-by: Tom Carrio <tom@carrio.dev>
Signed-off-by: Tom Carrio <tom@carrio.dev>
tcarrio force-pushed the feat/php-81-min-version branch from fb44796 to 09dbb02 Compare Signed-off-by: Tom Carrio <tom@carrio.dev>
| @tcarrio what's the status of this? Can you use any help moving things forward? We're looking to adopt this SDK, so maybe we could be of assistance here. |
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
This PR
Updates the minimum supported version of the SDK to PHP 8.1
Introduces new PHP language features including readonly properties, enumerations,
[...$array]overarray_merge($array)Related Issues
Resolves #108
Follow-up Tasks
General TODOs before leaving
DRAFT:How to test
Locally, you can run
composer run testto execute the full test suiteRemotely, see GitHub CI runs