Workaround for the local variable limits of binaryen's binary parser #83
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Binaryen's binary parser currently enforces a limit of 50 000 locals per function (see WebAssembly/binaryen#6677). To avoid reaching this limit, this first compiles the generated code with wasm-opt with a limited number of optimization passes before calling wasm-merge. Otherwise, wasm-merge (which does not perform any optimization) can produce a binary with an overly large number of locals, that will be rejected by other binaryen tools.
| This is fixed by WebAssembly/binaryen#6973 |
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
Binaryen's binary parser currently enforces a limit of 50 000 locals per function (see WebAssembly/binaryen#6677). To avoid reaching this limit, this first compiles the generated code with wasm-opt with a limited number of optimization passes before calling wasm-merge. Otherwise, wasm-merge (which does not perform any optimization) can produce a binary with an overly large number of locals, that will be rejected by other binaryen tools.