Re-enable binary.wast spec test #6677
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
kripken approved these changes Jun 18, 2024
| PTAL at the latest commit, which imposes a much smaller limit on the number of locals to avoid allocation failure on CI. |
tlively force-pushed the parser-unreachable-fallback-fix branch from 1d5e9aa to cebdb16 Compare kripken approved these changes Jun 18, 2024
| // the stack to become prior children of future expressions or to be | ||
| // implicitly dropped at the end of the scope. | ||
| *children[i].childp = builder.builder.makeUnreachable(); | ||
| continue; |
There was a problem hiding this comment.
pushed this branch so it should be updated again. That's a downside of this more manual workflow; graphite would push all the downstream branches for me automatically.
tlively force-pushed the malformed-binary-fixes branch from 089de6e to 11f2969 Compare | Now I've fixed a bunch of memory leaks by using |
kripken approved these changes Jun 18, 2024
Fix the wast parser to accept IDs on quoted modules, remove tests that are invalidated by the multimemory proposal, and add validation that the total number of variables in a function is less than 2^32 and that the code section is present if there is a non-empty function section.
tlively force-pushed the malformed-binary-fixes branch from d13267b to 9ca487b Compare 
Closed
This was referenced Sep 24, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
Fix the wast parser to accept IDs on quoted modules, remove tests that are
invalidated by the multimemory proposal, and add validation that the total
number of variables in a function is less than 2^32 and that the code section is
present if there is a non-empty function section.