v18.20.3 proposal #53028
Merged
v18.20.3 proposal #53028
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
As a temporary measure to unblock the CI, skip the RSA implicit rejection test when Node.js is built against a dynamically linked OpenSSL. PR-URL: #52542 Refs: #52537 Refs: nodejs-private/node-private#525 Refs: https://hackerone.com/reports/2269177 Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Michael Dawson <midawson@redhat.com>
Original commit message: Make bitfields only as wide as necessary for enums clang now complains when a BitField for an enum is too wide. We could suppress this, but it seems kind of useful from an uninformed distance, so I made a few bitfields smaller instead. (For AddressingMode, since its size is target-dependent, I added an explicit underlying type to the enum instead, which suppresses the diag on a per-enum basis.) This is without any understanding of the code I'm touching. Especially the change in v8-internal.h feels a bit risky to me. Bug: chromium:1348574 Change-Id: I73395de593045036b72dadf4e3147b5f7e13c958 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3794708 Commit-Queue: Nico Weber <thakis@chromium.org> Reviewed-by: Leszek Swirski <leszeks@chromium.org> Reviewed-by: Hannes Payer <hpayer@chromium.org> Auto-Submit: Nico Weber <thakis@chromium.org> Cr-Commit-Position: refs/heads/main@{#82109} Refs: v8/v8@d15d49b PR-URL: #52337 Fixes: #52230 Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com>
Hard code the value of the host parameter to `common.localhostIPv4` in `server.listen()` and `net.connect()`. This 1. ensures that the client `socket._handle` is not reinitialized during connection due to the family autodetection algorithm, preventing `parser.consume()` from being called with an invalid `socket._handle` parameter. 2. works around an issue in the FreeBSD 12 machine where the stress test is run where some sockets get stuck after connection. PR-URL: #49574 Backport-PR-URL: #52384 Closes: #49565 Fixes: #49564 Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com> Reviewed-By: James M Snell <jasnell@gmail.com>
The maximum number of parsers in the free list is set to 1000. However the test does not need to use this maximum. Reduce it to 50. Refs: #50228 (comment) PR-URL: #50240 Backport-PR-URL: #52384 Fixes: #49564 Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com> Reviewed-By: Vinícius Lourenço Claro Cardoso <contact@viniciusl.com.br>
PR-URL: #52257 Refs: nodejs/Release#984 Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Richard Lau <rlau@redhat.com> Reviewed-By: Ruy Adorno <ruy@vlt.sh> Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com> Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
PR-URL: #50441 Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Marco Ippolito <marcoippolito54@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
PR-URL: #51581 Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
PR-URL: #51948 Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Marco Ippolito <marcoippolito54@gmail.com> Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com>
PR-URL: #52395 Reviewed-By: Marco Ippolito <marcoippolito54@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Mohammed Keyvanzadeh <mohammadkeyvanzade94@gmail.com> Reviewed-By: Michael Dawson <midawson@redhat.com> Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com>
PR-URL: #51655 Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Marco Ippolito <marcoippolito54@gmail.com> Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com> Reviewed-By: Ulises Gascón <ulisesgascongonzalez@gmail.com>
PR-URL: #52138 Reviewed-By: Yagiz Nizipli <yagiz.nizipli@sentry.io> Reviewed-By: Michael Dawson <midawson@redhat.com> Reviewed-By: Marco Ippolito <marcoippolito54@gmail.com> Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com>
PR-URL: #52381 Refs: #51670 Reviewed-By: Daniel Lemire <daniel@lemire.me> Reviewed-By: Vinícius Lourenço Claro Cardoso <contact@viniciusl.com.br> Reviewed-By: Matteo Collina <matteo.collina@gmail.com> Reviewed-By: Robert Nagy <ronagy@icloud.com> Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com> Reviewed-By: Filip Skokan <panva.ip@gmail.com>
PR-URL: #52473 Reviewed-By: Richard Lau <rlau@redhat.com> Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Marco Ippolito <marcoippolito54@gmail.com>
PR-URL: #52351 Reviewed-By: Luke Karrys <luke@lukekarrys.com> Reviewed-By: Michael Dawson <midawson@redhat.com> Reviewed-By: Mohammed Keyvanzadeh <mohammadkeyvanzade94@gmail.com> Reviewed-By: Marco Ippolito <marcoippolito54@gmail.com> Reviewed-By: Ulises Gascón <ulisesgascongonzalez@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
PR-URL: #52027 Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com> Reviewed-By: Marco Ippolito <marcoippolito54@gmail.com> Reviewed-By: Ulises Gascón <ulisesgascongonzalez@gmail.com> Reviewed-By: Mohammed Keyvanzadeh <mohammadkeyvanzade94@gmail.com> Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
PR-URL: #52028 Reviewed-By: Yagiz Nizipli <yagiz.nizipli@sentry.io> Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com> Reviewed-By: Marco Ippolito <marcoippolito54@gmail.com> Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com> Reviewed-By: Ulises Gascón <ulisesgascongonzalez@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
PR-URL: #50460 Reviewed-By: Mohammed Keyvanzadeh <mohammadkeyvanzade94@gmail.com> Reviewed-By: Moshe Atlow <moshe@atlow.co.il> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
PR-URL: #50457 Reviewed-By: Mohammed Keyvanzadeh <mohammadkeyvanzade94@gmail.com> Reviewed-By: Moshe Atlow <moshe@atlow.co.il> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Marco Ippolito <marcoippolito54@gmail.com>
PR-URL: #50457 Reviewed-By: Mohammed Keyvanzadeh <mohammadkeyvanzade94@gmail.com> Reviewed-By: Moshe Atlow <moshe@atlow.co.il> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Marco Ippolito <marcoippolito54@gmail.com>
PR-URL: #51317 Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
PR-URL: #51457 Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Moshe Atlow <moshe@atlow.co.il> Reviewed-By: Michaël Zasso <targos@protonmail.com>
The thread-safe function's finalizer is not called in conjunction with the garbage collection of a JS value. In fact, it keeps a strong reference to the JS function it is expected to call. Thus, it is safe to make calls that affect GC state from its body. PR-URL: #51801 Reviewed-By: Michael Dawson <midawson@redhat.com> Reviewed-By: Chengzhong Wu <legendecas@gmail.com>
PR-URL: #52458 Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Marco Ippolito <marcoippolito54@gmail.com> Reviewed-By: Mohammed Keyvanzadeh <mohammadkeyvanzade94@gmail.com>
PR-URL: #51291 Reviewed-By: Stephen Belanger <admin@stephenbelanger.com> Reviewed-By: Jiawen Geng <technicalcute@gmail.com>
PR-URL: #51400 Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Marco Ippolito <marcoippolito54@gmail.com>
PR-URL: #51319 Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
PR-URL: #51584 Reviewed-By: Marco Ippolito <marcoippolito54@gmail.com> Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
PR-URL: #51796 Reviewed-By: Marco Ippolito <marcoippolito54@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com>
PR-URL: #52767 Reviewed-By: Richard Lau <rlau@redhat.com> Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Michaël Zasso <targos@protonmail.com>
Member
| This should be added if possible: #51290 |
At the point of `FreeEnvironment` and onwards, no JavaScript execution associated with the Environment should be triggered. Avoid draining platform tasks that can trigger JavaScript execution in `FreeEnvironment`. The holder of `node::Environment` should immediately call `node::MultiIsolatePlatform::UnregisterIsolate` and `v8::Isolate::Dispose` to cancel pending foreground tasks and join concurrent tasks after the environment was freed. `NodePlatform` can properly handle the case in `RunForegroundTask` when an Isolate out-lives its associated `node::Environment`. PR-URL: #51290 Fixes: #47748 Fixes: #49344 Reviewed-By: Vinícius Lourenço Claro Cardoso <contact@viniciusl.com.br> Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Notable changes: This release fixes a regression introduced in Node.js 18.19.0 where `http.server.close()` was incorrectly closing idle connections. A fix has also been included for compiling Node.js from source with newer versions of Clang. The list of keys used to sign releases has been synchronized with the current list from the `main` branch. Updated dependencies: - acorn updated to 8.11.3. - acorn-walk updated to 8.3.2. - ada updated to 2.7.8. - c-ares updated to 1.28.1. - corepack updated to 0.28.0. - nghttp2 updated to 1.61.0. - ngtcp2 updated to 1.3.0. - npm updated to 10.7.0. Includes a fix from npm@10.5.1 to limit the number of open connections. - simdutf updated to 5.2.4. - zlib updated to 1.3.0.1-motley-7d77fb7. PR-URL: #53028
richardlau force-pushed the v18.20.3-proposal branch from 192fe4a to 64903b1 Compare 
github-actions bot removed the request-ci 
This comment was marked as outdated.
This comment was marked as outdated.
Member
Member Author
Collaborator
| CI: https://ci.nodejs.org/job/node-test-pull-request/59260/ CITGM: |
Member Author
While that's not a lot of "new" failures, for Content-Length is set when using a FormData body with fetch (3544.837845ms) /home/iojs/tmp/citgm_tmp/6ba972b9-9a01-41bc-bdcf-2022f809a1ae/undici/undici-fetch.js:12862 Error.captureStackTrace(err, this); ^ TypeError: fetch failed at /home/iojs/tmp/citgm_tmp/6ba972b9-9a01-41bc-bdcf-2022f809a1ae/undici/undici-fetch.js:12862:13 { [cause]: HeadersOverflowError: Headers Overflow Error at Parser.trackHeader (/home/iojs/tmp/citgm_tmp/6ba972b9-9a01-41bc-bdcf-2022f809a1ae/undici/undici-fetch.js:5749:37) at Parser.onHeaderField (/home/iojs/tmp/citgm_tmp/6ba972b9-9a01-41bc-bdcf-2022f809a1ae/undici/undici-fetch.js:5723:14) at wasm_on_header_field (/home/iojs/tmp/citgm_tmp/6ba972b9-9a01-41bc-bdcf-2022f809a1ae/undici/undici-fetch.js:5539:34) at wasm://wasm/0002f80e:wasm-function[41]:0x84cb at wasm://wasm/0002f80e:wasm-function[20]:0x605b at Parser.execute (/home/iojs/tmp/citgm_tmp/6ba972b9-9a01-41bc-bdcf-2022f809a1ae/undici/undici-fetch.js:5665:26) at Parser.readMore (/home/iojs/tmp/citgm_tmp/6ba972b9-9a01-41bc-bdcf-2022f809a1ae/undici/undici-fetch.js:5644:16) at TLSSocket.<anonymous> (/home/iojs/tmp/citgm_tmp/6ba972b9-9a01-41bc-bdcf-2022f809a1ae/undici/undici-fetch.js:5972:18) at TLSSocket.emit (node:events:517:28) at emitReadable_ (node:internal/streams/readable:633:12) { code: 'UND_ERR_HEADERS_OVERFLOW' } } Node.js v18.20.3Also
(most of these don't show up in the comparison table because they failed with 18.20.2 for other reasons) I can recreate this on my local Linux development machine (with undici 16.17.0, which I guess has just been released). Fails: |
Member Author
Member
| We would need to investigate this. Fastify uses Undici internally, so I guess those things are connected. @ronag @ShogunPanda could you take a look as well? |
Member
| Just to verify, I've been trying to isolate the issue and it seems is not strictly related to the one shared ( For |
7 tasks
Contributor
| I agree with @metcoder95. I think this failures are not related to node and thus we can proceed with this release. |
Member Author
👍 Thanks @metcoder95 and @ShogunPanda for looking at this. I'll proceed with the release as planned tomorrow. |
Member
| undici v6.18 is out, with a fix if you want to try again. |
Member Author
| Release CI with 64903b1: https://ci-release.nodejs.org/job/iojs+release/10213/ |
richardlau added a commit that referenced this pull request May 21, 2024
Notable changes: This release fixes a regression introduced in Node.js 18.19.0 where `http.server.close()` was incorrectly closing idle connections. A fix has also been included for compiling Node.js from source with newer versions of Clang. The list of keys used to sign releases has been synchronized with the current list from the `main` branch. Updated dependencies: - acorn updated to 8.11.3. - acorn-walk updated to 8.3.2. - ada updated to 2.7.8. - c-ares updated to 1.28.1. - corepack updated to 0.28.0. - nghttp2 updated to 1.61.0. - ngtcp2 updated to 1.3.0. - npm updated to 10.7.0. Includes a fix from npm@10.5.1 to limit the number of open connections. - simdutf updated to 5.2.4. - zlib updated to 1.3.0.1-motley-7d77fb7. PR-URL: #53028
richardlau added a commit to nodejs/nodejs.org that referenced this pull request May 21, 2024
5 tasks
github-merge-queue bot pushed a commit to nodejs/nodejs.org that referenced this pull request May 21, 2024
github-merge-queue bot pushed a commit to nodejs/nodejs.org that referenced this pull request May 21, 2024
eliphazbouye pushed a commit to eliphazbouye/node that referenced this pull request Jun 20, 2024
Notable changes: This release fixes a regression introduced in Node.js 18.19.0 where `http.server.close()` was incorrectly closing idle connections. A fix has also been included for compiling Node.js from source with newer versions of Clang. The list of keys used to sign releases has been synchronized with the current list from the `main` branch. Updated dependencies: - acorn updated to 8.11.3. - acorn-walk updated to 8.3.2. - ada updated to 2.7.8. - c-ares updated to 1.28.1. - corepack updated to 0.28.0. - nghttp2 updated to 1.61.0. - ngtcp2 updated to 1.3.0. - npm updated to 10.7.0. Includes a fix from npm@10.5.1 to limit the number of open connections. - simdutf updated to 5.2.4. - zlib updated to 1.3.0.1-motley-7d77fb7. PR-URL: nodejs#53028
bmeck pushed a commit to bmeck/node that referenced this pull request Jun 22, 2024
Notable changes: This release fixes a regression introduced in Node.js 18.19.0 where `http.server.close()` was incorrectly closing idle connections. A fix has also been included for compiling Node.js from source with newer versions of Clang. The list of keys used to sign releases has been synchronized with the current list from the `main` branch. Updated dependencies: - acorn updated to 8.11.3. - acorn-walk updated to 8.3.2. - ada updated to 2.7.8. - c-ares updated to 1.28.1. - corepack updated to 0.28.0. - nghttp2 updated to 1.61.0. - ngtcp2 updated to 1.3.0. - npm updated to 10.7.0. Includes a fix from npm@10.5.1 to limit the number of open connections. - simdutf updated to 5.2.4. - zlib updated to 1.3.0.1-motley-7d77fb7. PR-URL: nodejs#53028
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
2024-05-21, Version 18.20.3 'Hydrogen' (LTS), @richardlau
Notable Changes
This release fixes a regression introduced in Node.js 18.19.0 where
http.server.close()was incorrectly closing idle connections.A fix has also been included for compiling Node.js from source with newer versions of Clang.
The list of keys used to sign releases has been synchronized with the current list from the
mainbranch.Updated dependencies
Commits
0c260e10e7] - deps: update zlib to 1.3.0.1-motley-7d77fb7 (Node.js GitHub Bot) #525161152d7f919] - deps: update zlib to 1.3.0.1-motley-24c07df (Node.js GitHub Bot) #52199755399db9d] - deps: update zlib to 1.3.0.1-motley-24342f6 (Node.js GitHub Bot) #52123af3e32073b] - deps: update ada to 2.7.8 (Node.js GitHub Bot) #52517e4ea2db58b] - deps: update c-ares to 1.28.1 (Node.js GitHub Bot) #5228514e857bea2] - deps: update corepack to 0.28.0 (Node.js GitHub Bot) #526167f5dd44ca6] - deps: upgrade npm to 10.7.0 (npm team) #5276778f84ebb09] - deps: update ngtcp2 to 1.3.0 (Node.js GitHub Bot) #517961f489a3753] - deps: update ngtcp2 to 1.2.0 (Node.js GitHub Bot) #515843034968225] - deps: update ngtcp2 to 1.1.0 (Node.js GitHub Bot) #513191aa9da467f] - deps: add nghttp3/**/.deps to .gitignore (Luigi Pinca) #5140028c0c78c9a] - deps: update ngtcp2 and nghttp3 (James M Snell) #512918fd5a35364] - deps: upgrade npm to 10.5.2 (npm team) #524582c53ff31c9] - deps: update acorn-walk to 8.3.2 (Node.js GitHub Bot) #5145712f28f33c2] - deps: update acorn to 8.11.3 (Node.js GitHub Bot) #51317dddb7eb3e0] - deps: update acorn-walk to 8.3.1 (Node.js GitHub Bot) #50457c86550e607] - deps: update acorn-walk to 8.3.0 (Node.js GitHub Bot) #504579500817f66] - deps: update acorn to 8.11.2 (Node.js GitHub Bot) #504607a8c7b6275] - deps: update ada to 2.7.7 (Node.js GitHub Bot) #52028b199889943] - deps: update corepack to 0.26.0 (Node.js GitHub Bot) #52027052b0ba0c6] - deps: upgrade npm to 10.5.1 (npm team) #52351209823d3af] - deps: update simdutf to 5.2.4 (Node.js GitHub Bot) #524735114cbe18a] - deps: update simdutf to 5.2.3 (Yagiz Nizipli) #52381be30309ea0] - deps: update simdutf to 5.0.0 (Daniel Lemire) #52138b56f66e250] - deps: update simdutf to 4.0.9 (Node.js GitHub Bot) #51655a9f3b9d9d1] - deps: update nghttp2 to 1.61.0 (Node.js GitHub Bot) #523951b6fa70620] - deps: update nghttp2 to 1.60.0 (Node.js GitHub Bot) #519483c9dbbf4d4] - deps: update nghttp2 to 1.59.0 (Node.js GitHub Bot) #51581e28316da54] - deps: update nghttp2 to 1.58.0 (Node.js GitHub Bot) #50441678641f470] - deps: V8: cherry-pick d15d49b09dc7 (Bo Anderson) #523371147fee7d9] - doc: remove ableist language from crypto (Jamie King) #520635e93eae972] - doc: add release key for marco-ippolito (marco-ippolito) #522576689a98488] - http: remove closeIdleConnections function while calling server close (Kumar Rishav) #5233671616e8a8a] - node-api: make tsfn accept napi_finalize once more (Gabriel Schulhof) #51801d9d9e62474] - src: avoid draining platform tasks at FreeEnvironment (Chengzhong Wu) #51290e5fc8ec9fc] - test: skip v8-updates/test-linux-perf (Michaël Zasso) #49639351ef189ca] - test: v8: Add test-linux-perf-logger test suite (Luke Albao) #503525cec2efc31] - test: reduce the number of requests and parsers (Luigi Pinca) #502405186e453d9] - test: deflake test-http-regr-Segfault innode::Environment::KickNextTick#2928 (Luigi Pinca) #49574c60cd67e1c] - test: skip test for dynamically linked OpenSSL (Richard Lau) #52542cc @nodejs/releasers