Skip to content

deps: update ngtcp2 and nghttp3, update quic impls #51291

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 2 commits into from
Closed

deps: update ngtcp2 and nghttp3, update quic impls #51291

wants to merge 2 commits into from

Conversation

@jasnell
Copy link
Member

@jasnell jasnell commented Dec 26, 2023 •
edited
Loading

Updates the ngtcp2 and nghttp3 dependencies and various bits of code that rely on it.
@nodejs-github-bot
Copy link
Collaborator

nodejs-github-bot commented Dec 26, 2023

Review requested:

  • @nodejs/gyp
@nodejs-github-bot nodejs-github-bot added needs-ci PRs that need a full CI run. quic Issues and PRs related to the QUIC implementation / HTTP/3. labels Dec 26, 2023
@jasnell jasnell marked this pull request as ready for review December 27, 2023 00:53
@jasnell jasnell requested a review from Qard December 27, 2023 00:56
@nodejs-github-bot

This comment was marked as outdated.

Sign in to view
@nodejs-github-bot

This comment was marked as outdated.

Sign in to view
@nodejs-github-bot

This comment was marked as outdated.

Sign in to view
@anonrig
Copy link
Member

anonrig commented Dec 27, 2023

I'll review this tomorrow 👍
gengjiawen
gengjiawen reviewed Dec 27, 2023
View reviewed changes
This was referenced Dec 27, 2023
Closed
Closed
@nodejs-github-bot

This comment was marked as outdated.

Sign in to view
anonrig
anonrig reviewed Dec 27, 2023
View reviewed changes
@nodejs-github-bot

This comment was marked as outdated.

Sign in to view
@nodejs-github-bot

This comment was marked as outdated.

Sign in to view
@nodejs-github-bot
Copy link
Collaborator

nodejs-github-bot commented Dec 27, 2023 •
edited by jasnell
Loading

CI: https://ci.nodejs.org/job/node-test-pull-request/56565/ 💚
@jasnell jasnell added lib / src Issues and PRs related to general changes in the lib or src directory. author ready PRs that have at least one approval, no pending requests for changes, and a CI started. needs-ci PRs that need a full CI run. dependencies Pull requests that update a dependency file. commit-queue Add this label to land a pull request using GitHub Actions. and removed needs-ci PRs that need a full CI run. labels Dec 27, 2023
@nodejs-github-bot nodejs-github-bot added commit-queue-failed An error occurred while landing this pull request using GitHub Actions. and removed commit-queue Add this label to land a pull request using GitHub Actions. labels Dec 28, 2023
@nodejs-github-bot
Copy link
Collaborator

nodejs-github-bot commented Dec 28, 2023

Commit Queue failed
- Loading data for nodejs/node/pull/51291 ✔ Done loading data for nodejs/node/pull/51291 ----------------------------------- PR info ------------------------------------ Title deps: update ngtcp2 and nghttp3, update quic impls (#51291) Author James M Snell (@jasnell) Branch jasnell:quic-part-9 -> nodejs:main Labels lib / src, author ready, needs-ci, quic, dependencies Commits 2 - deps: update ngtcp2 and nghttp3 - quic: update quic impl to use latest ngtcp2/nghttp3 Committers 1 - James M Snell PR-URL: https://github.com/nodejs/node/pull/51291 Reviewed-By: Stephen Belanger ------------------------------ Generated metadata ------------------------------ PR-URL: https://github.com/nodejs/node/pull/51291 Reviewed-By: Stephen Belanger -------------------------------------------------------------------------------- ⚠ Commits were pushed since the last approving review: ⚠ - deps: update ngtcp2 and nghttp3 ⚠ - quic: update quic impl to use latest ngtcp2/nghttp3 ℹ This PR was created on Tue, 26 Dec 2023 23:30:04 GMT ✔ Approvals: 1 ✔ - Stephen Belanger (@Qard): https://github.com/nodejs/node/pull/51291#pullrequestreview-1796691870 ✘ This PR needs to wait 119 more hours to land (or 0 hours if there is one more approval) ✘ Last GitHub CI failed ℹ Last Full PR CI on 2023-12-27T19:28:53Z: https://ci.nodejs.org/job/node-test-pull-request/56565/ - Querying data for job/node-test-pull-request/56565/ ✔ Last Jenkins CI successful -------------------------------------------------------------------------------- ✔ Aborted `git node land` session in /home/runner/work/node/node/.ncu
https://github.com/nodejs/node/actions/runs/7352086887
@gengjiawen gengjiawen added commit-queue Add this label to land a pull request using GitHub Actions. and removed commit-queue-failed An error occurred while landing this pull request using GitHub Actions. labels Dec 29, 2023
@nodejs-github-bot nodejs-github-bot added commit-queue-failed An error occurred while landing this pull request using GitHub Actions. and removed commit-queue Add this label to land a pull request using GitHub Actions. labels Dec 29, 2023
@nodejs-github-bot
Copy link
Collaborator

nodejs-github-bot commented Dec 29, 2023

Commit Queue failed
- Loading data for nodejs/node/pull/51291 ✔ Done loading data for nodejs/node/pull/51291 ----------------------------------- PR info ------------------------------------ Title deps: update ngtcp2 and nghttp3, update quic impls (#51291) Author James M Snell (@jasnell) Branch jasnell:quic-part-9 -> nodejs:main Labels lib / src, author ready, needs-ci, quic, dependencies Commits 2 - deps: update ngtcp2 and nghttp3 - quic: update quic impl to use latest ngtcp2/nghttp3 Committers 1 - James M Snell PR-URL: https://github.com/nodejs/node/pull/51291 Reviewed-By: Stephen Belanger Reviewed-By: Jiawen Geng ------------------------------ Generated metadata ------------------------------ PR-URL: https://github.com/nodejs/node/pull/51291 Reviewed-By: Stephen Belanger Reviewed-By: Jiawen Geng -------------------------------------------------------------------------------- ℹ This PR was created on Tue, 26 Dec 2023 23:30:04 GMT ✔ Approvals: 2 ✔ - Stephen Belanger (@Qard): https://github.com/nodejs/node/pull/51291#pullrequestreview-1796691870 ✔ - Jiawen Geng (@gengjiawen): https://github.com/nodejs/node/pull/51291#pullrequestreview-1798809500 ✘ Last GitHub CI failed ℹ Last Full PR CI on 2023-12-28T23:37:07Z: https://ci.nodejs.org/job/node-test-pull-request/56565/ - Querying data for job/node-test-pull-request/56565/ ✔ Last Jenkins CI successful -------------------------------------------------------------------------------- ✔ Aborted `git node land` session in /home/runner/work/node/node/.ncu
https://github.com/nodejs/node/actions/runs/7355913366
@jasnell
Copy link
Member Author

jasnell commented Dec 29, 2023

Landed in 07f3df4...0bf1548
jasnell added a commit that referenced this pull request Dec 29, 2023
@jasnell
deps: update ngtcp2 and nghttp3
86ca72a 
PR-URL: #51291 Reviewed-By: Stephen Belanger <admin@stephenbelanger.com> Reviewed-By: Jiawen Geng <technicalcute@gmail.com>
jasnell added a commit that referenced this pull request Dec 29, 2023
@jasnell
quic: update quic impl to use latest ngtcp2/nghttp3
0bf1548 
PR-URL: #51291 Reviewed-By: Stephen Belanger <admin@stephenbelanger.com> Reviewed-By: Jiawen Geng <technicalcute@gmail.com>
@jasnell jasnell closed this Dec 29, 2023
@zcbenz zcbenz mentioned this pull request Dec 30, 2023
Merged
RafaelGSS pushed a commit that referenced this pull request Jan 2, 2024
@jasnell @RafaelGSS
deps: update ngtcp2 and nghttp3
e53cbb2 
PR-URL: #51291 Reviewed-By: Stephen Belanger <admin@stephenbelanger.com> Reviewed-By: Jiawen Geng <technicalcute@gmail.com>
RafaelGSS pushed a commit that referenced this pull request Jan 2, 2024
@jasnell @RafaelGSS
quic: update quic impl to use latest ngtcp2/nghttp3
7ecf994 
PR-URL: #51291 Reviewed-By: Stephen Belanger <admin@stephenbelanger.com> Reviewed-By: Jiawen Geng <technicalcute@gmail.com>
@RafaelGSS RafaelGSS mentioned this pull request Jan 2, 2024
Merged
@targos targos mentioned this pull request Jan 30, 2024
Closed
@richardlau richardlau added the dont-land-on-v20.x PRs that should not land on the v20.x-staging branch and should not be released in v20.x. label Mar 25, 2024
richardlau pushed a commit that referenced this pull request May 10, 2024
@jasnell @richardlau
deps: update ngtcp2 and nghttp3
28c0c78 
PR-URL: #51291 Reviewed-By: Stephen Belanger <admin@stephenbelanger.com> Reviewed-By: Jiawen Geng <technicalcute@gmail.com>
@richardlau richardlau mentioned this pull request May 16, 2024
Merged
@targos targos mentioned this pull request May 23, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

author ready PRs that have at least one approval, no pending requests for changes, and a CI started. commit-queue-failed An error occurred while landing this pull request using GitHub Actions. dependencies Pull requests that update a dependency file. dont-land-on-v20.x PRs that should not land on the v20.x-staging branch and should not be released in v20.x. lib / src Issues and PRs related to general changes in the lib or src directory. needs-ci PRs that need a full CI run. quic Issues and PRs related to the QUIC implementation / HTTP/3.

6 participants

@jasnell @nodejs-github-bot @anonrig @Qard @gengjiawen @richardlau