Skip to content

fix(blob, file, tests): Minor improvements for Blob and File implementations #120

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 10 commits into from
Oct 24, 2021
Merged

fix(blob, file, tests): Minor improvements for Blob and File implementations #120

Changes from 1 commit
Commits
Show all changes
10 commits
Select commit Hold shift + click to select a range
1838f89
Use private class fields in parts initialization directly.
octet-stream Sep 27, 2021
81c73fb
Move Blob.slice implementation into a generator function.
octet-stream Sep 27, 2021
238c2fb
Move encoder initialization outside the loop
octet-stream Sep 27, 2021
56838bf
Improve errors reported by Blob constructor.
octet-stream Sep 27, 2021
355a789
Simulate WebIDL type casting for lastModified in File constructor.
octet-stream Sep 27, 2021
05f23d9
Add cancel method for Blob.stream() underlying source.
octet-stream Sep 27, 2021
39ce808
Fix indentation inconsistency.
octet-stream Sep 27, 2021
e0f5895
Revert changes for Blob.slice() to previous approach.
octet-stream Oct 16, 2021
d7892e9
Code style fix for slice method.
octet-stream Oct 16, 2021
5e57899
Use getReader in blob stream cancellation test instead of Symbol.asyn…
octet-stream Oct 17, 2021
File filter

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Move encoder initialization outside the loop
  • Loading branch information
@octet-stream
octet-stream committed Sep 27, 2021
commit 238c2fb445986e4317099e6071ed0f7c23a59af8
3 changes: 2 additions & 1 deletion index.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -110,6 +110,7 @@ const _Blob = class Blob {

if (options === null) options = {};

const encoder = new TextEncoder()
for (const element of blobParts) {
let part;
if (ArrayBuffer.isView(element)) {
Expand All @@ -119,7 +120,7 @@ const _Blob = class Blob {
} else if (element instanceof Blob) {
part = element;
} else {
part = new TextEncoder().encode(element);
part = encoder.encode(element);
}

this.#size += ArrayBuffer.isView(part) ? part.byteLength : part.size;
Expand Down