fix(blob, file, tests): Minor improvements for Blob and File implementations #120
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
The purpose of this PR is:
This PR includes minor improvements and fixes for File and Blob internals
This is what had to change:
Blob.stream().cancel()
triggersiterator.return()
on underlying source;FilePropertyBag.lastModified
to match browsers behaviour (This behaviour tested in Chrome, Firefox and Safari), now NaN values will be interpreted as0
rather thanDate.now()
;MoveBlob.slice()
implementation outside the Blob class and implement it as generator function. Since blob treats iterable objects as a sequence and behaviour looks the same;This is what like reviewers to know:
This PR is more of a housekeeping with minor changes only. This also changes one thing in terms of File behaviour, just to match File implementations in browsers.
docs:
,fix(area):
,feat(area):
orbreaking(area):