Skip to content

Fix/dcm2niix #2498

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 15 commits into from
Mar 23, 2018
Merged

Fix/dcm2niix #2498

Changes from 1 commit
Commits
Show all changes
15 commits
Select commit Hold shift + click to select a range
6ecd4a9
ref: dcm2niix interface
mgxd Mar 16, 2018
26d82fe
tst: add datalad/dcm2niix to testing
mgxd Mar 16, 2018
b60b4d8
fix: dcm2niix doctest
mgxd Mar 16, 2018
6d7bb8d
tst: move dcm2niix test to circle
mgxd Mar 16, 2018
43c43a7
fix: forgotten changes
mgxd Mar 16, 2018
4c2e885
tst: remove dcm2niix and datalad testing until neurodocker fixes
mgxd Mar 16, 2018
ec72e99
tst: add check for dcm2niix executable
mgxd Mar 16, 2018
140b715
enh: add version checking
mgxd Mar 17, 2018
e904bbb
fix: version parsing
mgxd Mar 17, 2018
7ba24f1
doc: add test [skip-ci]
mgxd Mar 19, 2018
333c5a3
Merge branch 'fix/dcm2niix' of github.com:mgxd/nipype into fix/dcm2niix
mgxd Mar 19, 2018
715de9c
Merge branch 'master' of git://github.com/nipy/nipype into fix/dcm2niix
mgxd Mar 19, 2018
dd0503f
fix: address review comments
mgxd Mar 23, 2018
c92289b
Merge branch 'master' of git://github.com/nipy/nipype into fix/dcm2niix
mgxd Mar 23, 2018
41c45b9
fix: argstr and doctest
mgxd Mar 23, 2018
File filter

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
doc: add test [skip-ci]
  • Loading branch information
@mgxd
mgxd committed Mar 19, 2018
commit 7ba24f12eae8151e009e0de588350ac1943071d0
1 change: 1 addition & 0 deletions nipype/interfaces/dcm2nii.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -364,6 +364,7 @@ class Dcm2niix(CommandLine):
>>> flags = '-'.join([val.strip() + ' ' for val in sorted(' '.join(converter.cmdline.split()[1:-1]).split('-'))])
>>> flags
' -5 -b y -m n -o ds005 -s n -t n -v n -x n -z y '
Copy link
Member

@effigies effigies Mar 22, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What is the point of this flags line, if we're already showing cmdline?
Copy link
Member Author

@mgxd mgxd Mar 23, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm fine to remove this as well, just kept around since it previously existed
Copy link
Member

@effigies effigies Mar 23, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like @satra specifically added this in #1529. Guessing the flag ordering was non-deterministic, since he also added #doctest: +SKIP to the cmdline line. If the cmdline check is working consistently, I'd say go ahead and drop.
>>> converter.run() # doctest: +SKIP
"""

input_spec = Dcm2niixInputSpec
Expand Down