Skip to content

feat: Enable a few more newer Node.js rules #397

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Jan 10, 2022
Merged

feat: Enable a few more newer Node.js rules #397

Changes from 2 commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
5161c4e
Enable a few more rules
XhmikosR Jan 6, 2022
729df3c
Update .eslintrc.js
XhmikosR Jan 6, 2022
85126b1
Merge branch 'main' into patch-1
ehmicky Jan 10, 2022
File filter

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 0 additions & 10 deletions .eslintrc.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -220,9 +220,6 @@ module.exports = {
// The `sortCharacterClasses` option is not very useful
'unicorn/better-regex': [2, { sortCharacterClasses: false }],

// TODO: enable once https://github.com/sindresorhus/eslint-plugin-unicorn/issues/1343 is fixed
'unicorn/prefer-prototype-methods': 0,

// Too strict
'unicorn/no-null': 0,
'unicorn/no-array-reduce': 0,
Expand All @@ -243,13 +240,6 @@ module.exports = {
// TODO: enable those rules
'unicorn/no-process-exit': 0,
'unicorn/import-style': 0,
// TODO: enable after dropping Node 8 support
'unicorn/prefer-optional-catch-binding': 0,
'unicorn/prefer-string-trim-start-end': 0,
// TODO: enable after dropping Node <12 support
'unicorn/numeric-separators-style': 0,
'unicorn/prefer-array-flat': 0,
'unicorn/prefer-array-flat-map': 0,
},
overrides: [
{
Expand Down