feat: Enable a few more newer Node.js rules

[XhmikosR]

🎉 Thanks for sending this pull request! 🎉

Please make sure the title is clear and descriptive.

If you are fixing a typo or documentation, please skip these instructions.

Otherwise please fill in the sections below.

Which problem is this pull request solving?

Example: I'm always frustrated when [...]

List other issues or pull requests related to this problem

Example: This fixes #5012

Describe the solution you've chosen

Example: I've fixed this by [...]

Describe alternatives you've considered

Example: Another solution would be [...]

Checklist

Please add a x inside each checkbox:

• I have read the contribution guidelines.
• The status checks are successful (continuous integration). Those can be seen below.

[XhmikosR]

These are the changes on the cli repo: netlify/cli@main...XhmikosR:test-eslint

unicorn/prefer-object-from-entries might be good to enable too (see the separate patch), but not all cases are auto-fixable:

> netlify-cli@8.6.5 format:fix:lint > cross-env-shell eslint --fix $npm_package_config_eslint error: Prefer `Object.fromEntries()` over `Array#reduce()` (unicorn/prefer-object-from-entries) at site\scripts\generate-command-data.js:25:6: 23 | .filter((option) => !option.hidden) 24 | .sort(sortOptions) > 25 | .reduce((prev, cur) => { | ^ 26 | const name = cur.long.replace('--', '') 27 | const contentType = cur.argChoices ? cur.argChoices.join(' | ') : 'string' 28 | error: Prefer `Object.fromEntries()` over `Array#reduce()` (unicorn/prefer-object-from-entries) at src\utils\addons\validation.js:10:37: 8 | 9 | const updateConfigValues = function (allowedConfig, currentConfig, newConfig) { > 10 | return Object.keys(allowedConfig).reduce((acc, key) => { | ^ 11 | if (newConfig[key]) { 12 | acc[key] = newConfig[key] 13 | return acc error: Prefer `Object.fromEntries()` over `Array#reduce()` (unicorn/prefer-object-from-entries) at src\utils\parse-raw-flags.js:14:24: 12 | 13 | const parseRawFlags = function (raw) { > 14 | const rawFlags = raw.reduce((acc, curr, index, array) => { | ^ 15 | if (/^-{1,2}/.test(curr)) { 16 | const key = curr.replace(/^-{1,2}/, '') 17 | const next = array[index + 1] 3 errors found. 

[XhmikosR]

Let me know how do you want to proceed with unicorn/prefer-object-from-entries. Maybe we should land this as is and cut a new version and then try to enable unicorn/prefer-object-from-entries?

[ehmicky]

Thanks a lot @XhmikosR!

About Object.fromEntries(), I believe the ESLint Unicorn rule is unfortunately too strict when it comes to some legitimate usage of Array.reduce() as you mention, so I would personally not favor enabling this specific rule.

[ascorbic]

In future, can updates that enable new rules be treated as breaking changes and released as a new major version?

[ehmicky]

Absolutely. Sorry, and thanks for the reminder @ascorbic 🙏

[ascorbic]

Thanks!