Fix versions not being flagged for review after 2nd level approval requeue #23948
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
Fixes mozilla/addons#15822
Description
This refactors how versions are passed when flagging for review in
CinderAddonHandledByReviewers, always passing down aVersionqueryset.Context
We were expecting version strings in
flag_for_human_review()(which is inefficient and confusing) but the requeue method was passing a Version queryset directly.Later inside
flag_for_human_review()there was a fallback that worked for the listed channel that caused us to flag thecurrent_version(with further handling for the case where it's an appeal and there is nocurrent_versionanymore). But for unlisted, nothing, so we didn't flag anything.Testing
Expected result:
Actual result before this patch: