Skip to content

fixing context image not created when manually running releases #214

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 8 commits into from
Jul 1, 2025

Conversation

nammn
Copy link
Collaborator

@nammn nammn commented Jun 30, 2025

Summary

This pull request includes several updates to improve code readability, streamline imports, and enhance observability in the mongodb-kubernetes project. The changes encompass YAML file formatting, Python test import simplifications, and additional tracing attributes in the pipeline logic.

Pipeline Enhancements:

  • Updated the should_skip_arm64 function in pipeline.py to accept a BuildConfiguration parameter. Otherwise - we are skipping arm64 releases during manually triggered releases
  • Added OpenTelemetry tracing attributes to capture architecture details and release metadata in the get_architectures_set, inner, and build_image_generic functions, improving observability. [1] [2] [3].
    • the idea here is to add as much visibility as I could easily add

Proof of Work

  • passing ci

Checklist

  • Have you linked a jira ticket and/or is the ticket in the title?
  • Have you checked whether your jira ticket required DOCSP changes?
  • Have you checked for release_note changes?

Reminder (Please remove this when merging)

  • Please try to Approve or Reject Changes the PR, keep PRs in review as short as possible
  • Our Short Guide for PRs: Link
  • Remember the following Communication Standards - use comment prefixes for clarity:
    • blocking: Must be addressed before approval.
    • follow-up: Can be addressed in a later PR or ticket.
    • q: Clarifying question.
    • nit: Non-blocking suggestions.
    • note: Side-note, non-actionable. Example: Praise
    • --> no prefix is considered a question
@nammn nammn marked this pull request as ready for review June 30, 2025 16:09
@nammn nammn requested a review from a team as a code owner June 30, 2025 16:09
@nammn nammn requested review from SimonBaeumer and anandsyncs June 30, 2025 16:09
@@ -8,9 +8,9 @@ metadata:
certified: "true"
containerImage: quay.io/mongodb/mongodb-kubernetes:1.1.0
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

that should go away with this: #210

Copy link
Member

@mircea-cosbuc mircea-cosbuc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. I added some suggestions to avoid confusion later when revisiting the code.

nammn and others added 4 commits July 1, 2025 10:03
@nammn nammn enabled auto-merge (squash) July 1, 2025 08:10
@nammn nammn merged commit 74638f2 into master Jul 1, 2025
6 of 7 checks passed
@nammn nammn deleted the fix-agent-image-creation branch July 1, 2025 09:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
3 participants