Skip to content

Conversation

@nammn
Copy link
Collaborator

@nammn nammn commented Jun 23, 2025

Summary

This pull request includes updates to improve YAML file handling and fixes a minor issue in the update_standalone function. The most important changes are grouped below:

YAML Handling Improvements:

Bug Fix in Function Logic:

Proof of Work

  • consistent yaml formatting for linter (passing unit test variant)

Checklist

  • Have you linked a jira ticket and/or is the ticket in the title?
  • Have you checked whether your jira ticket required DOCSP changes?
  • Have you checked for release_note changes?

Reminder (Please remove this when merging)

  • Please try to Approve or Reject Changes the PR, keep PRs in review as short as possible
  • Our Short Guide for PRs: Link
  • Remember the following Communication Standards - use comment prefixes for clarity:
    • blocking: Must be addressed before approval.
    • follow-up: Can be addressed in a later PR or ticket.
    • q: Clarifying question.
    • nit: Non-blocking suggestions.
    • note: Side-note, non-actionable. Example: Praise
    • --> no prefix is considered a question
@nammn nammn requested a review from a team as a code owner June 23, 2025 12:43
@nammn nammn requested review from Copilot, m1kola and viveksinghggits and removed request for m1kola and viveksinghggits June 23, 2025 12:43
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR standardizes YAML formatting by setting a consistent line width and fixes unintended tuple creation in the update_standalone function by removing trailing commas.

  • Added yaml.width = 4096 to prevent inconsistent wrapping in CI vs. local runs
  • Removed trailing commas in update_standalone to ensure each installer update is invoked properly

Reviewed Changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.

File Description
scripts/evergreen/release/update_helm_values_files.py Removed trailing commas after function calls in update_standalone
scripts/evergreen/release/helm_files_handler.py Added yaml.width = 4096 to update_standalone_installer for wider YAML lines
@nammn nammn merged commit 13d8bc6 into master Jul 1, 2025
35 checks passed
@nammn nammn deleted the fix-precommit-csv branch July 1, 2025 08:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

4 participants