Skip to content

PYTHON-3385 Add prose test for RewrapManyDataKey #1034

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 10 commits into from
Aug 12, 2022
Merged

PYTHON-3385 Add prose test for RewrapManyDataKey #1034

Changes from 1 commit
Commits
Show all changes
10 commits
Select commit Hold shift + click to select a range
088a7b8
PYTHON-3385 Add prose test for RewrapManyDataKey
blink1073 Aug 10, 2022
ce8c4f0
fix master_keys usage
blink1073 Aug 10, 2022
76ff36c
address review
blink1073 Aug 10, 2022
b615518
address review
blink1073 Aug 10, 2022
23da78f
address review
blink1073 Aug 10, 2022
1bca8d2
address review
blink1073 Aug 11, 2022
4f3946b
address review
blink1073 Aug 11, 2022
035fbf2
add tls options
blink1073 Aug 11, 2022
be94b66
address review
blink1073 Aug 12, 2022
1d06312
remove unused prop
blink1073 Aug 12, 2022
File filter

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
address review
  • Loading branch information
@blink1073
blink1073 committed Aug 11, 2022
commit 1bca8d2955fa40caf370c21f678627409120dc3e
4 changes: 2 additions & 2 deletions test/test_encryption.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2224,8 +2224,8 @@ class TestRewrapWithSeparateClientEncryption(EncryptionIntegrationTest):
}

def test_rewrap(self):
for src_provider in ALL_KMS_PROVIDERS:
for dst_provider in ALL_KMS_PROVIDERS:
for src_provider in self.MASTER_KEYS:
for dst_provider in self.MASTER_KEYS:
with self.subTest(src_provider=src_provider, dst_provider=dst_provider):
self.run_test(src_provider, dst_provider)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The test says we still need to test the "local" provider:

For "local", do not set a masterKey document.

I think that means we need to add

... "kmip": {}, "local": None, }
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

They used local: {} in the C driver, I'll go with that.

Expand Down