PYTHON-3385 Add prose test for RewrapManyDataKey #1034
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
ShaneHarvey requested changes Aug 10, 2022
ShaneHarvey reviewed Aug 10, 2022
ShaneHarvey reviewed Aug 10, 2022
ShaneHarvey reviewed Aug 10, 2022
ShaneHarvey requested changes Aug 10, 2022
There was a problem hiding this comment.
One last issue:
[2022/08/10 22:47:12.652] ERROR: test_rewrap (test.test_encryption.TestRewrapWithSeparateClientEncryption) (src_provider='local', dst_provider='local') [2022/08/10 22:47:12.653] ---------------------------------------------------------------------- [2022/08/10 22:47:12.653] Traceback (most recent call last): [2022/08/10 22:47:12.653] File "/data/mci/1f2979f82d22e06506f6cff1d940194e/src/test/test_encryption.py", line 2230, in test_rewrap [2022/08/10 22:47:12.653] self.run_test(src_provider, dst_provider) [2022/08/10 22:47:12.653] File "/data/mci/1f2979f82d22e06506f6cff1d940194e/src/test/test_encryption.py", line 2247, in run_test [2022/08/10 22:47:12.653] master_key=self.MASTER_KEYS[src_provider], kms_provider=src_provider [2022/08/10 22:47:12.653] KeyError: 'local' 
Fixed |
ShaneHarvey reviewed Aug 11, 2022
| for src_provider in self.MASTER_KEYS: | ||
| for dst_provider in self.MASTER_KEYS: | ||
| with self.subTest(src_provider=src_provider, dst_provider=dst_provider): | ||
| self.run_test(src_provider, dst_provider) |
There was a problem hiding this comment.
The test says we still need to test the "local" provider:
For "local", do not set a masterKey document.
I think that means we need to add
... "kmip": {}, "local": None, } There was a problem hiding this comment.
They used local: {} in the C driver, I'll go with that.
ShaneHarvey reviewed Aug 11, 2022
test/test_encryption.py Outdated
| "local": {}, | ||
| } | ||
| | ||
| KMS_TLS_OPTS = { |
There was a problem hiding this comment.
I think the tlsCAFile is only valid/needed for kmip. Can we use the existing KMS_TLS_OPTS global instead of adding a new self.KMS_TLS_OPTS?
ShaneHarvey approved these changes Aug 12, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
No description provided.