Skip to content

Semantic update for env var #17

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 29, 2022
Merged

Semantic update for env var #17

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 2 additions & 3 deletions serverless.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,10 +14,8 @@ provider:
- "s3:*"
Resource:
- "*"
deploymentBucket: # Custom configuration for deployment bucket is unique and put here
deploymentBucket: # Custom configuration for deployment bucket
blockPublicAccess: true
environment:
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@karikarshivani hi - quick question - was there an advantage to originally keeping this separate ?
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @rgs1109! Yes, the provider.environment section defines the environment variable globally (so all functions can access the value) and the functions.<function_name>.environment section defines the environment variable locally (so only that function can access the value). Hope that helps! :)
INPUT_BUCKET: ${env:INPUT_BUCKET}

functions:
saf:
Expand All @@ -32,6 +30,7 @@ functions:
existing: true # test pending in CMS
environment:
COMMAND_STRING: ${env:COMMAND_STRING}
INPUT_BUCKET: ${env:INPUT_BUCKET}
INPUT_PREFIX: ${env:INPUT_PREFIX, ""}
OUTPUT_BUCKET: ${env:OUTPUT_BUCKET, env:INPUT_BUCKET}
OUTPUT_PREFIX: ${env:OUTPUT_PREFIX, "results/"}
Expand Down