Semantic update for env var #17
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Signed-off-by: karikarshivani <karikarshivani@gmail.com>
karikarshivani changed the title 
rgs1109 reviewed Jun 28, 2022
| deploymentBucket: # Custom configuration for deployment bucket is unique and put here | ||
| deploymentBucket: # Custom configuration for deployment bucket | ||
| blockPublicAccess: true | ||
| environment: |
There was a problem hiding this comment.
@karikarshivani hi - quick question - was there an advantage to originally keeping this separate ?
There was a problem hiding this comment.
Hey @rgs1109! Yes, the provider.environment section defines the environment variable globally (so all functions can access the value) and the functions.<function_name>.environment section defines the environment variable locally (so only that function can access the value). Hope that helps! :)
rgs1109 approved these changes Jun 29, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
Moved
INPUT_BUCKETenvironment variable with othersSigned-off-by: karikarshivani karikarshivani@gmail.com