Skip to content

Conversation

@karthiknadig
Copy link
Member

No description provided.

Kartik Raj added 2 commits November 9, 2020 13:03
* Add FSWatching locator base class * Correct glob pattern to not match python3.2whoa * Add documentation of python binary watcher * Fix lint errors * Update ignore list * Add disposable registry * Modify FSWatching Locator * Code reviews * Use string[] * Remove list disposable getter
@karthiknadig karthiknadig changed the base branch from main to release-2020.11 November 9, 2020 21:05
@karthiknadig karthiknadig changed the title Cherry pic fixes for tests. Cherry pic fixes into release for tests. Nov 9, 2020
@sonarqubecloud
Copy link

sonarqubecloud bot commented Nov 9, 2020

Kudos, SonarCloud Quality Gate passed!

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities (and Security Hotspot 0 Security Hotspots to review)
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@codecov-io
Copy link

Codecov Report

Merging #14673 (bbfcd42) into release-2020.11 (2c2b7e1) will decrease coverage by 0.09%.
The diff coverage is 34.11%.

Impacted file tree graph

@@ Coverage Diff @@ ## release-2020.11 #14673 +/- ## =================================================== - Coverage 65.11% 65.01% -0.10%  =================================================== Files 541 543 +2 Lines 25377 25425 +48 Branches 3587 3593 +6 =================================================== + Hits 16523 16531 +8  - Misses 8177 8217 +40  Partials 677 677 
Impacted Files Coverage Δ
src/client/common/platform/fileSystemWatcher.ts 22.22% <5.88%> (-2.23%) ⬇️
...pythonEnvironments/common/pythonBinariesWatcher.ts 33.33% <12.50%> (-28.21%) ⬇️
src/client/common/syncDisposableRegistry.ts 25.00% <25.00%> (ø)
...nments/base/locators/lowLevel/fsWatchingLocator.ts 34.37% <34.37%> (ø)
src/client/pythonEnvironments/base/locator.ts 73.33% <60.00%> (-10.00%) ⬇️
...discovery/locators/services/windowsStoreLocator.ts 97.91% <83.33%> (+11.12%) ⬆️
...ocators/services/globalVirtualEnvronmentLocator.ts 100.00% <100.00%> (+3.57%) ⬆️
src/client/common/utils/platform.ts 68.00% <0.00%> (-4.00%) ⬇️
...rc/client/pythonEnvironments/common/commonUtils.ts 85.93% <0.00%> (-1.57%) ⬇️
... and 1 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2c2b7e1...bbfcd42. Read the comment docs.

@karthiknadig karthiknadig merged commit 5eab81d into microsoft:release-2020.11 Nov 9, 2020
karthiknadig added a commit that referenced this pull request Nov 26, 2020
* Cherry pick from main (#14644) * Update shipped wheels version (#14615) * Update shipped wheels version * News item * Remove redundant files (#14620) * Add extension dependencies at build time (#14636) * Use Node 12.15 in Insiders and Release GitHub Actions (#14641) * Use Node 12.15 on all Insiders and Release GitHub Actions jobs (#14642) Co-authored-by: Joyce Er <joyceerhuiling@gmail.com> * Cherry pic fixes into release for tests. (#14673) * Added FSWatching base class and made related changes (#14605) * Add FSWatching locator base class * Correct glob pattern to not match python3.2whoa * Add documentation of python binary watcher * Fix lint errors * Update ignore list * Add disposable registry * Modify FSWatching Locator * Code reviews * Use string[] * Remove list disposable getter * Fix failing global virtual env watcher tests (#14633) Co-authored-by: Kartik Raj <karraj@microsoft.com> * Version, change log and cherrypicks for nov release (#14696) * change log updates * Update gifs * Fix for interpreter selection (#14693) * Fix for interpreter selection * Fix linting errors * Minor tweak to property removal * Cherry pick "Bind function to correct this for workspace syms" (#14743) * Fix #14674: Enable overriding "pythonPath" in the launcher Fix #12462: Update launch.json schema to add "python" and remove "pythonPath" Split the "pythonPath" debug property into "python", "debugAdapterPython", and "debugLauncherPython". Do most debug config validation on fully expanded property values via resolveDebugConfigurationWithSubstitutedVariables(). Add fixups for legacy launch.json with "pythonPath". * Point release change log and version update (#14750) * Point release change log and version update * Fix process picker (#14700) * Workaround VSCode bug for process picker * Fix how we pass in icons to VSCode * update change log with cherry pick Co-authored-by: Kartik Raj <karraj@microsoft.com> Co-authored-by: Joyce Er <joyceerhuiling@gmail.com> Co-authored-by: Kartik Raj <karraj@microsoft.com> Co-authored-by: Jake Bailey <5341706+jakebailey@users.noreply.github.com> Co-authored-by: Pavel Minaev <pminaev@microsoft.com>
@karthiknadig karthiknadig deleted the cherry1 branch December 10, 2020 20:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

3 participants