Skip to content

Conversation

@karthiknadig
Copy link
Member

No description provided.

@karthiknadig karthiknadig added the no-changelog No news entry required label Nov 6, 2020
@sonarqubecloud
Copy link

sonarqubecloud bot commented Nov 6, 2020

Kudos, SonarCloud Quality Gate passed!

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities (and Security Hotspot 0 Security Hotspots to review)
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

Copy link

@joyceerhl joyceerhl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks Karthik 😊

@codecov-io
Copy link

codecov-io commented Nov 6, 2020

Codecov Report

Merging #14644 into release-2020.11 will not change coverage.
The diff coverage is 100.00%.

Impacted file tree graph

@@ Coverage Diff @@ ## release-2020.11 #14644 +/- ## ================================================ Coverage 65.10% 65.10% ================================================ Files 541 541 Lines 25377 25377 Branches 3587 3587 ================================================ Hits 16522 16522 - Misses 8177 8178 +1  + Partials 678 677 -1 
Impacted Files Coverage Δ
...t/jupyter/languageserver/notebookConcatDocument.ts 7.81% <ø> (ø)
...client/jupyter/languageserver/notebookConverter.ts 1.67% <ø> (ø)
.../jupyter/languageserver/notebookMiddlewareAddon.ts 3.84% <ø> (ø)
src/client/activation/languageClientMiddleware.ts 32.46% <100.00%> (ø)
src/client/common/utils/platform.ts 68.00% <0.00%> (-4.00%) ⬇️
...rc/client/pythonEnvironments/common/commonUtils.ts 87.50% <0.00%> (+1.56%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1b41519...5cb50cc. Read the comment docs.

@karthiknadig
Copy link
Member Author

Tests have all passed not sure why github thinks they haven't.

@karthiknadig karthiknadig merged commit 2c2b7e1 into microsoft:release-2020.11 Nov 6, 2020
karthiknadig added a commit that referenced this pull request Nov 26, 2020
* Cherry pick from main (#14644) * Update shipped wheels version (#14615) * Update shipped wheels version * News item * Remove redundant files (#14620) * Add extension dependencies at build time (#14636) * Use Node 12.15 in Insiders and Release GitHub Actions (#14641) * Use Node 12.15 on all Insiders and Release GitHub Actions jobs (#14642) Co-authored-by: Joyce Er <joyceerhuiling@gmail.com> * Cherry pic fixes into release for tests. (#14673) * Added FSWatching base class and made related changes (#14605) * Add FSWatching locator base class * Correct glob pattern to not match python3.2whoa * Add documentation of python binary watcher * Fix lint errors * Update ignore list * Add disposable registry * Modify FSWatching Locator * Code reviews * Use string[] * Remove list disposable getter * Fix failing global virtual env watcher tests (#14633) Co-authored-by: Kartik Raj <karraj@microsoft.com> * Version, change log and cherrypicks for nov release (#14696) * change log updates * Update gifs * Fix for interpreter selection (#14693) * Fix for interpreter selection * Fix linting errors * Minor tweak to property removal * Cherry pick "Bind function to correct this for workspace syms" (#14743) * Fix #14674: Enable overriding "pythonPath" in the launcher Fix #12462: Update launch.json schema to add "python" and remove "pythonPath" Split the "pythonPath" debug property into "python", "debugAdapterPython", and "debugLauncherPython". Do most debug config validation on fully expanded property values via resolveDebugConfigurationWithSubstitutedVariables(). Add fixups for legacy launch.json with "pythonPath". * Point release change log and version update (#14750) * Point release change log and version update * Fix process picker (#14700) * Workaround VSCode bug for process picker * Fix how we pass in icons to VSCode * update change log with cherry pick Co-authored-by: Kartik Raj <karraj@microsoft.com> Co-authored-by: Joyce Er <joyceerhuiling@gmail.com> Co-authored-by: Kartik Raj <karraj@microsoft.com> Co-authored-by: Jake Bailey <5341706+jakebailey@users.noreply.github.com> Co-authored-by: Pavel Minaev <pminaev@microsoft.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

no-changelog No news entry required

4 participants