Skip to content

feat: add support for Teams meeting start/end events #3757

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 16 commits into from
Jun 18, 2021
Merged

feat: add support for Teams meeting start/end events #3757

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
16 commits
Select commit Hold shift + click to select a range
98037ca
add support for Teams meeting start/end events
mdrichardson Jun 16, 2021
1b0c412
Merge branch 'main' into teamsMeetingEvents
mdrichardson Jun 16, 2021
ab072fe
api-extractor fix
mdrichardson Jun 16, 2021
769eb21
camelCase event payloads
mdrichardson Jun 16, 2021
cbc67ac
add method comment for casing
mdrichardson Jun 16, 2021
adef19a
adjust tests for casing changes
mdrichardson Jun 17, 2021
4c55053
minor doc adjustment
mdrichardson Jun 17, 2021
8b39ff8
don't shortcut parent dispatchEventActivity()
mdrichardson Jun 17, 2021
f2645e6
add err
mdrichardson Jun 17, 2021
8eda7e6
Revert "don't shortcut parent dispatchEventActivity()"
mdrichardson Jun 18, 2021
0ace8c1
Merge branch 'main' into teamsMeetingEvents
mdrichardson Jun 18, 2021
52a30ba
PR review adjustments
mdrichardson Jun 18, 2021
c56cc8d
tilde
mdrichardson Jun 18, 2021
0d464d5
make tests work w/ runtypes
mdrichardson Jun 18, 2021
00c66d6
cap fix
mdrichardson Jun 18, 2021
74e8767
Merge branch 'main' into teamsMeetingEvents
mdrichardson Jun 18, 2021
File filter

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
40 changes: 20 additions & 20 deletions libraries/botbuilder-core/src/activityHandler.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -457,7 +457,7 @@ export class ActivityHandler extends ActivityHandlerBase {
* @param context The context object for the current turn.
*
* @remarks
* Overwrite this method to use custom logic for emitting events.
* Override this method to use custom logic for emitting events.
*
* The default logic is to call any handlers registered via [onTurn](xref:botbuilder-core.ActivityHandler.onTurn),
* and then continue by calling [ActivityHandlerBase.onTurnActivity](xref:botbuilder-core.ActivityHandlerBase.onTurnActivity).
Expand All @@ -474,7 +474,7 @@ export class ActivityHandler extends ActivityHandlerBase {
* @param context The context object for the current turn.
*
* @remarks
* Overwrite this method to support channel-specific behavior across multiple channels.
* Override this method to support channel-specific behavior across multiple channels.
*
* The default logic is to call any handlers registered via
* [onMessage](xref:botbuilder-core.ActivityHandler.onMessage),
Expand All @@ -489,7 +489,7 @@ export class ActivityHandler extends ActivityHandlerBase {
* @param context The context object for the current turn.
*
* @remarks
* Overwrite this method to support channel-specific behavior across multiple channels.
* Override this method to support channel-specific behavior across multiple channels.
* The default logic is to check for a signIn invoke and handle that
* and then continue by calling [defaultNextEvent](xref:botbuilder-core.ActivityHandler.defaultNextEvent).
*/
Expand Down Expand Up @@ -531,7 +531,7 @@ export class ActivityHandler extends ActivityHandlerBase {
* @param context The context object for the current turn.
*
* @remarks
* Overwrite this method to support channel-specific behavior across multiple channels.
* Override this method to support channel-specific behavior across multiple channels.
*/
protected async onSignInInvoke(context: TurnContext): Promise<void> {
throw new InvokeException(StatusCodes.NOT_IMPLEMENTED);
Expand All @@ -556,7 +556,7 @@ export class ActivityHandler extends ActivityHandlerBase {
* @param context The context object for the current turn.
*
* @remarks
* Overwrite this method to support channel-specific behavior across multiple channels.
* Override this method to support channel-specific behavior across multiple channels.
*
* The default logic is to call any handlers registered via
* [onEndOfConversationActivity](xref:botbuilder-core.ActivityHandler.onMessage),
Expand All @@ -572,7 +572,7 @@ export class ActivityHandler extends ActivityHandlerBase {
* @param context The context object for the current turn.
*
* @remarks
* Overwrite this method to support channel-specific behavior across multiple channels.
* Override this method to support channel-specific behavior across multiple channels.
*
* The default logic is to call any handlers registered via
* [onTypingActivity](xref:botbuilder-core.ActivityHandler.onTypingActivity),
Expand All @@ -588,7 +588,7 @@ export class ActivityHandler extends ActivityHandlerBase {
* @param context The context object for the current turn.
*
* @remarks
* Overwrite this method to support channel-specific behavior across multiple channels.
* Override this method to support channel-specific behavior across multiple channels.
*
* The default logic is to call any handlers registered via
* [onInstallationUpdateActivity](xref:botbuilder-core.ActivityHandler.onInstallationUpdateActivity),
Expand Down Expand Up @@ -624,7 +624,7 @@ export class ActivityHandler extends ActivityHandlerBase {
* @param context The context object for the current turn.
*
* @remarks
* Overwrite this method to support channel-specific behavior across multiple channels or to add
* Override this method to support channel-specific behavior across multiple channels or to add
* custom conversation update sub-type events.
*
* The default logic is:
Expand All @@ -651,7 +651,7 @@ export class ActivityHandler extends ActivityHandlerBase {
* @param context The context object for the current turn.
*
* @remarks
* Overwrite this method to support channel-specific behavior across multiple channels.
* Override this method to support channel-specific behavior across multiple channels.
*
* The default logic is to call any handlers registered via
* [onInstallationUpdateAdd](xref:botbuilder-core.ActivityHandler.onInstallationUpdateAdd),
Expand All @@ -667,7 +667,7 @@ export class ActivityHandler extends ActivityHandlerBase {
* @param context The context object for the current turn.
*
* @remarks
* Overwrite this method to support channel-specific behavior across multiple channels.
* Override this method to support channel-specific behavior across multiple channels.
*
* The default logic is to call any handlers registered via
* [onInstallationUpdateRemove](xref:botbuilder-core.ActivityHandler.onInstallationUpdateRemove),
Expand All @@ -683,7 +683,7 @@ export class ActivityHandler extends ActivityHandlerBase {
* @param context The context object for the current turn.
*
* @remarks
* Overwrite this method to support channel-specific behavior across multiple channels.
* Override this method to support channel-specific behavior across multiple channels.
*
* The default logic is to call any handlers registered via
* [onUnrecognizedActivityType](xref:botbuilder-core.ActivityHandler.onUnrecognizedActivityType),
Expand Down Expand Up @@ -743,7 +743,7 @@ export class ActivityHandler extends ActivityHandlerBase {
* @param context The context object for the current turn.
*
* @remarks
* Overwrite this method to support channel-specific behavior across multiple channels.
* Override this method to support channel-specific behavior across multiple channels.
*
* The default logic is to call any handlers registered via
* [onConversationUpdate](xref:botbuilder-core.ActivityHandler.onConversationUpdate),
Expand All @@ -762,7 +762,7 @@ export class ActivityHandler extends ActivityHandlerBase {
* @param context The context object for the current turn.
*
* @remarks
* Overwrite this method to support channel-specific behavior across multiple channels or to add
* Override this method to support channel-specific behavior across multiple channels or to add
* custom conversation update sub-type events.
*
* The default logic is:
Expand All @@ -786,7 +786,7 @@ export class ActivityHandler extends ActivityHandlerBase {
* @param context The context object for the current turn.
*
* @remarks
* Overwrite this method to support channel-specific behavior across multiple channels.
* Override this method to support channel-specific behavior across multiple channels.
*
* The default logic is to call any handlers registered via
* [onMessageReaction](xref:botbuilder-core.ActivityHandler.onMessageReaction),
Expand All @@ -806,7 +806,7 @@ export class ActivityHandler extends ActivityHandlerBase {
* @param context The context object for the current turn.
*
* @remarks
* Overwrite this method to support channel-specific behavior across multiple channels.
* Override this method to support channel-specific behavior across multiple channels.
*
* The default logic is to call any handlers registered via
* [onReactionsAdded](xref:botbuilder-core.ActivityHandler.onReactionsAdded),
Expand All @@ -823,7 +823,7 @@ export class ActivityHandler extends ActivityHandlerBase {
* @param context The context object for the current turn.
*
* @remarks
* Overwrite this method to support channel-specific behavior across multiple channels.
* Override this method to support channel-specific behavior across multiple channels.
*
* The default logic is to call any handlers registered via
* [onReactionsRemoved](xref:botbuilder-core.ActivityHandler.onReactionsRemoved),
Expand All @@ -842,7 +842,7 @@ export class ActivityHandler extends ActivityHandlerBase {
* @param context The context object for the current turn.
*
* @remarks
* Overwrite this method to support channel-specific behavior across multiple channels or to add
* Override this method to support channel-specific behavior across multiple channels or to add
* custom message reaction sub-type events.
*
* The default logic is:
Expand All @@ -864,7 +864,7 @@ export class ActivityHandler extends ActivityHandlerBase {
* @param context The context object for the current turn.
*
* @remarks
* Overwrite this method to support channel-specific behavior across multiple channels.
* Override this method to support channel-specific behavior across multiple channels.
*
* The default logic is to call any handlers registered via
* [onEvent](xref:botbuilder-core.ActivityHandler.onEvent),
Expand All @@ -883,7 +883,7 @@ export class ActivityHandler extends ActivityHandlerBase {
* @param context The context object for the current turn.
*
* @remarks
* Overwrite this method to support channel-specific behavior across multiple channels or to add custom event sub-type events.
* Override this method to support channel-specific behavior across multiple channels or to add custom event sub-type events.
* For certain channels, such as Web Chat and custom Direct Line clients, developers can emit custom event activities from the client.
*
* The default logic is:
Expand All @@ -905,7 +905,7 @@ export class ActivityHandler extends ActivityHandlerBase {
* @param context The context object for the current turn.
*
* @remarks
* Overwrite this method to use custom logic for emitting events.
* Override this method to use custom logic for emitting events.
*
* The default logic is to call any handlers registered via [onDialog](xref:botbuilder-core.ActivityHandler.onDialog),
* and then complete the event emission process.
Expand Down
34 changes: 17 additions & 17 deletions libraries/botbuilder-core/src/activityHandlerBase.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,7 @@ import { ActivityTypes, ChannelAccount, MessageReaction, TurnContext } from '.';
import { InvokeResponse } from './invokeResponse';
import { StatusCodes } from './statusCodes';

// This key is exported internally so that subclassed ActivityHandlers and BotAdapters will not overwrite any already set InvokeResponses.
// This key is exported internally so that subclassed ActivityHandlers and BotAdapters will not override any already set InvokeResponses.
export const INVOKE_RESPONSE_KEY = Symbol('invokeResponse');

/**
Expand Down Expand Up @@ -37,7 +37,7 @@ export class ActivityHandlerBase {
* @param context The context object for the current turn.
*
* @remarks
* Overwrite this method to use custom logic for emitting events.
* Override this method to use custom logic for emitting events.
*
* The default logic is to call any type-specific and sub-type handlers registered via
* the various _on event_ methods. Type-specific events are defined for:
Expand Down Expand Up @@ -97,7 +97,7 @@ export class ActivityHandlerBase {
* @param context The context object for the current turn.
*
* @remarks
* Overwrite this method to run registered _message_ handlers and then continue the event
* Override this method to run registered _message_ handlers and then continue the event
* emission process.
*/
protected async onMessageActivity(context: TurnContext): Promise<void> {
Expand All @@ -110,7 +110,7 @@ export class ActivityHandlerBase {
* @param context The context object for the current turn.
*
* @remarks
* Overwrite this method to run registered _conversation update_ handlers and then continue the event
* Override this method to run registered _conversation update_ handlers and then continue the event
* emission process.
*
* The default logic is:
Expand Down Expand Up @@ -145,7 +145,7 @@ export class ActivityHandlerBase {
* @param context The context object for the current turn.
*
* @remarks
* Overwrite this method to run registered _message reaction_ handlers and then continue the event
* Override this method to run registered _message reaction_ handlers and then continue the event
* emission process.
*
* The default logic is:
Expand All @@ -168,7 +168,7 @@ export class ActivityHandlerBase {
* @param context The context object for the current turn.
*
* @remarks
* Overwrite this method to run registered _event_ handlers and then continue the event
* Override this method to run registered _event_ handlers and then continue the event
* emission process.
*/
protected async onEventActivity(context: TurnContext): Promise<void> {
Expand All @@ -181,7 +181,7 @@ export class ActivityHandlerBase {
* @param context The context object for the current turn.
*
* @remarks
* Overwrite this method to handle particular invoke calls.
* Override this method to handle particular invoke calls.
*/
protected async onInvokeActivity(context: TurnContext): Promise<InvokeResponse> {
return { status: StatusCodes.NOT_IMPLEMENTED };
Expand All @@ -193,7 +193,7 @@ export class ActivityHandlerBase {
* @param context The context object for the current turn.
*
* @remarks
* Overwrite this method to run registered _end of conversation_ handlers and then continue the event
* Override this method to run registered _end of conversation_ handlers and then continue the event
* emission process.
*/
protected async onEndOfConversationActivity(context: TurnContext): Promise<void> {
Expand All @@ -206,7 +206,7 @@ export class ActivityHandlerBase {
* @param context The context object for the current turn.
*
* @remarks
* Overwrite this method to run registered _typing_ handlers and then continue the event
* Override this method to run registered _typing_ handlers and then continue the event
* emission process.
*/
protected async onTypingActivity(context: TurnContext): Promise<void> {
Expand All @@ -219,7 +219,7 @@ export class ActivityHandlerBase {
* @param context The context object for the current turn.
*
* @remarks
* Overwrite this method to run registered _installationupdate_ handlers and then continue the event
* Override this method to run registered _installationupdate_ handlers and then continue the event
* emission process.
*/
protected async onInstallationUpdateActivity(context: TurnContext): Promise<void> {
Expand All @@ -241,7 +241,7 @@ export class ActivityHandlerBase {
* @param context The context object for the current turn.
*
* @remarks
* Overwrite this method to run registered _installationupdateadd_ handlers and then continue the event
* Override this method to run registered _installationupdateadd_ handlers and then continue the event
* emission process.
*/
protected async onInstallationUpdateAddActivity(context: TurnContext): Promise<void> {
Expand All @@ -254,7 +254,7 @@ export class ActivityHandlerBase {
* @param context The context object for the current turn.
*
* @remarks
* Overwrite this method to run registered _installationupdateremove_ handlers and then continue the event
* Override this method to run registered _installationupdateremove_ handlers and then continue the event
* emission process.
*/
protected async onInstallationUpdateRemoveActivity(context: TurnContext): Promise<void> {
Expand All @@ -267,7 +267,7 @@ export class ActivityHandlerBase {
* @param context The context object for the current turn.
*
* @remarks
* Overwrite this method to run registered _unrecognized_ handlers and then continue the event
* Override this method to run registered _unrecognized_ handlers and then continue the event
* emission process.
*/
protected async onUnrecognizedActivity(context: TurnContext): Promise<void> {
Expand All @@ -282,7 +282,7 @@ export class ActivityHandlerBase {
* @param context The context object for the current turn.
*
* @remarks
* Overwrite this method to run registered _members added_ handlers and then continue the event
* Override this method to run registered _members added_ handlers and then continue the event
* emission process.
*/
protected async onMembersAddedActivity(membersAdded: ChannelAccount[], context: TurnContext): Promise<void> {
Expand All @@ -297,7 +297,7 @@ export class ActivityHandlerBase {
* @param context The context object for the current turn.
*
* @remarks
* Overwrite this method to run registered _members removed_ handlers and then continue the event
* Override this method to run registered _members removed_ handlers and then continue the event
* emission process.
*/
protected async onMembersRemovedActivity(membersRemoved: ChannelAccount[], context: TurnContext): Promise<void> {
Expand All @@ -312,7 +312,7 @@ export class ActivityHandlerBase {
* @param context The context object for the current turn.
*
* @remarks
* Overwrite this method to run registered _reactions added_ handlers and then continue the event
* Override this method to run registered _reactions added_ handlers and then continue the event
* emission process.
*/
protected async onReactionsAddedActivity(reactionsAdded: MessageReaction[], context: TurnContext): Promise<void> {
Expand All @@ -327,7 +327,7 @@ export class ActivityHandlerBase {
* @param context The context object for the current turn.
*
* @remarks
* Overwrite this method to run registered _reactions removed_ handlers and then continue the event
* Override this method to run registered _reactions removed_ handlers and then continue the event
* emission process.
*/
protected async onReactionsRemovedActivity(
Expand Down
Loading