feat: add support for Teams meeting start/end events #3757
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
mdrichardson changed the title 
Pull Request Test Coverage Report for Build 951068226
💛 - Coveralls |
mdrichardson changed the title 
mdrichardson commented Jun 16, 2021
Comment on lines 1011 to 1012
| // The payload from Teams comes in with TitleCase keys, so we'll convert them to camelCase | ||
| // to maintain JSON and JS standard practices. |
There was a problem hiding this comment.
Note: This is intentional from Teams and not expected to change.
mdrichardson commented Jun 16, 2021
| * Specific details of a Teams meeting. | ||
| */ | ||
| export interface MeetingDetails { | ||
| interface MeetingDetailsBase { |
There was a problem hiding this comment.
Note: These interfaces were originally introduced in the PR that added getMeetingInfo(). Per Teams, the two schemas are intentionally different in the ways depicted below and not likely to change.
mdrichardson commented Jun 17, 2021
12 tasks
mdrichardson commented Jun 17, 2021
mdrichardson commented Jun 17, 2021
joshgummersall approved these changes Jun 18, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
Fixes #3724
Description
Adds support to TeamsActivityHandler for meeting start/end events.
Notes
Bots implementing this must add this to their
manifest.json:Note that somebody needs to actually start/join the meeting for this to work. The scheduled start/end times mean nothing for this event.
Testing