[ExecutionTests] Fix shader source to prevent OOB access for ExecutionTests::AtomicsShared64Test #7641
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
alsepkow changed the title 
| I lost access to a machine with a reliable repro. But I did validate that the test still passes with this change on another machine with the updated shader source. |
damyanp approved these changes Jul 12, 2025
tex3d reviewed Jul 14, 2025
bob80905 approved these changes Jul 21, 2025
bogner reviewed Jul 22, 2025
bogner approved these changes Jul 22, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
Fixes #5198.
ExecutionTests::AtomicsShared64Test could sporadically fail.
g_sint64Share is indexed with ix%3 + 1, which could lead to an out of bounds access.
Increase the size of g_sint64Share to 4 and ensure all values are initialized.