Skip to content
This repository was archived by the owner on Sep 11, 2024. It is now read-only.

Invite Dialog fixes #4233

Merged
merged 5 commits into from
Mar 19, 2020
Merged

Invite Dialog fixes #4233

merged 5 commits into from
Mar 19, 2020

Conversation

t3chguy
Copy link
Member

@t3chguy t3chguy commented Mar 18, 2020 •
edited
Loading

Fixes element-hq/element-web#12775

  • Fix vertical align of the textarea in Firefox fixing this broke it in Chrome so not dealing with it atm
  • Fix close button being no-op when in-flight:

    matrix-react-sdk/src/components/views/dialogs/InviteDialog.js

    Line 652 in 963c0a7

    // We do not want the user to close the dialog while an action is in progress
  • Backspace on an empty field should delete right-most target
  • Remove remove buttons on targets when request is in-flight
  • Lock textarea when request is in-flight
  • Update copy
  • Fix vertical spacing of the "pills"
  • Fix whole-modal scrolling, introduce AutoHideScrollbar (I was unable to accomplish this)

image
t3chguy added 5 commits March 18, 2020 21:08
@t3chguy
Update DM invite copy
22c8df9 
Signed-off-by: Michael Telatynski <7t3chguy@gmail.com>
@t3chguy
Invite dialog: backspace on empty field remove right-most target
dd9ead0 
Signed-off-by: Michael Telatynski <7t3chguy@gmail.com>
@t3chguy
Hide remove target buttons when busy
963c0a7 
Signed-off-by: Michael Telatynski <7t3chguy@gmail.com>
@t3chguy
disable textarea when busy
1dc30be 
Signed-off-by: Michael Telatynski <7t3chguy@gmail.com>
@t3chguy
don't block onFinished as there are other ways to close modal
fa6a937 
Signed-off-by: Michael Telatynski <7t3chguy@gmail.com>
@t3chguy t3chguy marked this pull request as ready for review March 19, 2020 10:18
@t3chguy t3chguy requested review from a team March 19, 2020 10:18
nadonomy
nadonomy approved these changes Mar 19, 2020
View reviewed changes
Copy link
Contributor

@nadonomy nadonomy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@t3chguy I'm approving this PR, but while you have a good understanding of the problem would you mind creating a new issue to track the scrollbar issue, for us to fix later?
@t3chguy t3chguy merged commit c616107 into develop Mar 19, 2020
@t3chguy t3chguy deleted the t3chguy/invite_fixes branch April 27, 2020 17:56
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

3 participants

@t3chguy @foldleft @nadonomy