This repository was archived by the owner on Sep 11, 2024. It is now read-only.
Implement new design for uploading/removing avatars #3733
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
|
|
|
|
…ithub.com/matrix-org/matrix-react-sdk into t3chguy/remove_avatar_2.0 � Conflicts: � res/css/views/settings/_ProfileSettings.scss
dbkr suggested changes Dec 16, 2019
| | ||
| // show a different AvatarSetting placeholder for RoomProfileSettings which is basically a clone of ProfileSettings | ||
| .mx_RoomSettingsDialog .mx_AvatarSetting_avatar .mx_AvatarSetting_avatarPlaceholder::before { | ||
| mask: url("$(res)/img/feather-customised/image.svg"); |
There was a problem hiding this comment.
avatar_placeholder.svg or something maybe?
dbkr approved these changes Dec 16, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
Fixes element-hq/element-web#8456
Fixes element-hq/element-web#11287
Based on new design:
Result:
