This repository was archived by the owner on Sep 11, 2024. It is now read-only.
Add ability to remove avatars #3719
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
… t3chguy/remove_avatar � Conflicts: � src/components/views/settings/ProfileSettings.js
Signed-off-by: Michael Telatynski <7t3chguy@gmail.com>
Signed-off-by: Michael Telatynski <7t3chguy@gmail.com>
Signed-off-by: Michael Telatynski <7t3chguy@gmail.com>
Signed-off-by: Michael Telatynski <7t3chguy@gmail.com>
Signed-off-by: Michael Telatynski <7t3chguy@gmail.com>
turt2live suggested changes Dec 12, 2019
| if (e.keyCode === KeyCode.ENTER || e.keyCode === KeyCode.SPACE) { | ||
| onChange(!checked); | ||
| e.stopPropagation(); | ||
| e.preventDefault(); |
There was a problem hiding this comment.
unrelated changes should probably be in their own PR for next time
| import sdk from "../../../index"; | ||
| | ||
| // TODO: Why is rendering a box with an overlay so complicated? Can the DOM be reduced? | ||
| const AvatarSetting = (props) => { |
There was a problem hiding this comment.
ooi why a function with a bunch of bootstrap instead of a tiny PureComponent class?
There was a problem hiding this comment.
Ability to use useContextMenu hook simplifies things
| Superseded by #3733 |
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
Fixes element-hq/element-web#8456
Fixes element-hq/element-web#11287
Based on
🎈
