This repository was archived by the owner on Sep 11, 2024. It is now read-only.
Change read markers to use CSS transitions #3674
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Removes one of the two places we use Velocity, so we're one step closer to getting rid of it for good. Should therefore fix the fact that Velocity is leaking data entries and therefore <hr> elements. Hopefully also makes the logic in getEventTiles incrementally simpler, if still somwewhat byzantine.
dbkr added a commit to element-hq/element-web that referenced this pull request Nov 26, 2019
So we can use names like easeInSine in CSS transitions rather than cubic-bezier(0.47, 0, 0.745, 0.715) Required for matrix-org/matrix-react-sdk#3674
|
|
turt2live approved these changes Nov 26, 2019
Sadly not - read markers == the green lines, read receipts == the little faces Yeah, they are quite edge-casey, especially around the MELS stuff: adding some tests made me a bit more confident about doing this. |
dbkr commented Nov 26, 2019
| }, 100); | ||
| }); | ||
| | ||
| it('shows only one ghost when the RM moves twice', function() { |
There was a problem hiding this comment.
I should say: this test was really testing that the animations didn't break (#254). The animations will now work fine however many ghosts we end up showing so this test is no longer useful as it shows multiple ghosts by design.
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
Removes one of the two places we use Velocity, so we're one step
closer to getting rid of it for good.
Should therefore fix the fact that Velocity is leaking data entries
and therefore
<hr>elements.Hopefully also makes the logic in getEventTiles incrementally simpler,
if still somwewhat byzantine.
Requires element-hq/element-web#11521