This repository was archived by the owner on Sep 11, 2024. It is now read-only.
Fix a bug where we tried to show two ghost read markers at once. #254
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
I think this was responsible for the readmarker just disappearing rather than animating. While we're here, decrease the delay on the animation, and instead make it take slightly longer to disappear.
| E_NO_ASSIGNEE? :) I'm pretty dubious about changing the RM marker timing here - I personally find it quite helpful that it hangs around for 1s before starting to fade. But it could be Stockholm syndrome - is anyone else actually objecting to this? @AmandineLP @dbkr @kegsay |
... since they seem to be a bit contentious
| I've backed out the animation timing changes for now, so that we can focus on the actual bug fix. |
| lgtm |
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
I think this was responsible for the readmarker just disappearing rather than
animating (element-hq/element-web#1313).
While we're here, decrease the delay on the animation, and instead make it take
slightly longer to disappear.
[It's taken me about three days of hackery to put together a working test
framework to test this, but look! regression tests!]