Skip to content

Use new local timestamp for calls #1499

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 8 commits into from
Oct 12, 2020
Merged

Use new local timestamp for calls #1499

merged 8 commits into from
Oct 12, 2020

Conversation

@dbkr
Copy link
Member

@dbkr dbkr commented Oct 8, 2020 •
edited
Loading

  • Split out call event handling into its own class
  • Convert it to TypeScript
  • Update to use getLocalAge()
  • Add grace period to avoid ringing unless the user will actually have time to accept the call

First 3 commits are the extraction / TS conversion: the actual change is in the last commit.
dbkr added 4 commits October 8, 2020 11:10
@dbkr
Extract the call event handler out to its own class
487a9c0 
and convert it to TypeScript
@dbkr
copyright header
0df1a7d
@dbkr
use more enums
92c6332
@dbkr
Use getLocalAge() & add grace period
f518ea9 
Use the new local-age field for deciding whether a call is still valid or not. Also add a grace period so we don't ring half a second before the call becomes invalid.
@dbkr dbkr marked this pull request as ready for review October 8, 2020 11:02
@dbkr dbkr requested a review from a team October 8, 2020 11:02
@dbkr dbkr mentioned this pull request Oct 8, 2020
Merged
turt2live
turt2live approved these changes Oct 9, 2020
View reviewed changes
Copy link
Member

@turt2live turt2live left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

otherwise lgtm - thanks :D
@dbkr
Copy link
Member Author

dbkr commented Oct 9, 2020

sorry - couple more commits: I missed a reference to callList
@dbkr dbkr requested a review from turt2live October 9, 2020 17:17
@dbkr dbkr mentioned this pull request Oct 9, 2020
Merged
@dbkr dbkr merged commit 06044b3 into develop Oct 12, 2020
@t3chguy t3chguy deleted the dbkr/new_age_calls branch May 10, 2022 14:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

3 participants

@dbkr @turt2live