Fixes for call state machine #1503
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
and convert it to TypeScript
Use the new local-age field for deciding whether a call is still valid or not. Also add a grace period so we don't ring half a second before the call becomes invalid.
and different array syntax
* Set 'connecting' state before sending answer, otherwise it can race with ICE connecting * Ignore completed ice connection state: connected is what we care about * Null-check remotestream when stopping media * Comments
but special case it for now & don't send it: it needs voip v1
turt2live approved these changes Oct 9, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
race with ICE connecting
Based on #1499
Actual diff: pull/1499/head...pull/1503/head