Minor cleanup: fixed wrong usage of sprintf, it only takes 2 placeholders here and w…

[hostep]

…e gave it 3 arguments.

Description (*)

Found with running phpstan on level 0:

 ------ ------------------------------------------------------------------------ Line framework-message-queue/Consumer/Config/Validator/ConsumerInstance.php ------ ------------------------------------------------------------------------ 42 Call to sprintf contains 2 placeholders, 3 values given. ------ ------------------------------------------------------------------------ 

This PR fixes this, it doesn't fix anything major, as the code runs fine as-is and doesn't crash. So this is only a minor cleanup.

I've left the trailing comma, since that's accepted by PHP > 8.0 and it results in cleaner git diffs.

Related Pull Requests

Fixed Issues (if relevant)

Manual testing scenarios (*)

Nothing to test, the code wasn't behaving wrong before, this is just a minor cleanup.
The unit test for this class already tests for the correct exception message, so if unit tests are green, this can be considered good enough.

Questions or comments

Contribution checklist (*)

• Pull request has a meaningful description of its purpose
• All commits are accompanied by meaningful commit messages
• All new or changed code is covered with unit/integration tests (if applicable)
• README.md files for modified modules are updated and included in the pull request if any README.md predefined sections require an update
• All automated tests passed successfully (all builds are green)

Resolved issues:

1. resolves [Issue] Minor cleanup: fixed wrong usage of sprintf, it only takes 2 placeholders here and w… #39062: Minor cleanup: fixed wrong usage of sprintf, it only takes 2 placeholders here and w…

[m2-assistant]

Hi @hostep. Thank you for your contribution!
Here are some useful tips on how you can test your changes using Magento test environment.

Add the comment under your pull request to deploy test or vanilla Magento instance:

• @magento give me test instance - deploy test instance based on PR changes
• @magento give me 2.4-develop instance - deploy vanilla Magento instance

❗ Automated tests can be triggered manually with an appropriate comment:

• @magento run all tests - run or re-run all required tests against the PR changes
• @magento run <test-build(s)> - run or re-run specific test build(s)
  For example: @magento run Unit Tests

<test-build(s)> is a comma-separated list of build names.

Allowed build names are:

1. Database Compare
2. Functional Tests CE
3. Functional Tests EE
4. Functional Tests B2B
5. Integration Tests
6. Magento Health Index
7. Sample Data Tests CE
8. Sample Data Tests EE
9. Sample Data Tests B2B
10. Static Tests
11. Unit Tests
12. WebAPI Tests
13. Semantic Version Checker

You can find more information about the builds here
ℹ️ Run only required test builds during development. Run all test builds before sending your pull request for review.

---

For more details, review the Code Contributions documentation.
Join Magento Community Engineering Slack and ask your questions in #github channel.

[hostep]

@magento run all tests

[engcom-Charlie]

@magento run all tests

[engcom-Charlie]

Hi @hostep,

Thank you for your contribution!

✔️ QA Passed

Preconditions:

• Install fresh Magento 2.4-develop

Steps to reproduce

1. Execute
   vendor/bin/phpstan analyse lib/internal/Magento/Framework/MessageQueue/Consumer/Config/Validator/ConsumerInstance.php --level 0

Before: ✖️ 

After: ✔️

Build is failing hence moving this PR to Extended Testing.

[engcom-Charlie]

@magento create issue

[engcom-Charlie]

@magento run all tests

[engcom-Charlie]

@magento run Functional Tests CE, Functional Tests EE, WebAPI Tests

[engcom-Charlie]

@magento run all tests

[engcom-Charlie]

The Functional CE failures are different in recent 2 runs, seems to be flaky.

Run 1:
https://public-results-storage-prod.magento-testing-service.engineering/reports/magento/magento2/pull/38628/cc677f6ece906fd770625c41527e58dd/Functional/allure-report-ce/index.html#categories

Run 2:
https://public-results-storage-prod.magento-testing-service.engineering/reports/magento/magento2/pull/38628/d092cabf3f7138b5f7b7566a15c6f1e9/Functional/allure-report-ce/index.html#categories

[engcom-Charlie]

Some Functional EE test failures are different in recent 2 builds, one is constant in both the build. This test failure is a known failure and exits open JIRA for the same.

Run 1:
https://public-results-storage-prod.magento-testing-service.engineering/reports/magento/magento2/pull/38628/fd5b91e27a556b9c00652f529519ac60/Functional/allure-report-ee/index.html#categories

Run 2:
https://public-results-storage-prod.magento-testing-service.engineering/reports/magento/magento2/pull/38628/e92fa8c4d126ac46f97ae914ad9c0f6b/Functional/allure-report-ee/index.html#categories/7ab86c37ada5ce9839cb60a85ecf9b8f/fac5d2e9fe8720ca/

Known issues :
StorefrontCreateOrderAllQuantityGroupedProductOptionDefaultStockTest: #ACQE-6331

[engcom-Charlie]

In the recent 2 builds the Functional B2B failures are not consistent in recent 2 builds, seems to be flaky. Hence moving this PR to Merge in Progress.

Run 1:
No B2B failure

Run 2:
https://public-results-storage-prod.magento-testing-service.engineering/reports/magento/magento2/pull/38628/ce60b81a6d8495aa1a22322a9cdc21c0/Functional/allure-report-b2b/index.html#categories