- Notifications
You must be signed in to change notification settings - Fork 9.4k
Closed
Labels
Area: FrameworkComponent: Framework/ComponentIssue: ConfirmedGate 3 Passed. Manual verification of the issue completed. Issue is confirmedGate 3 Passed. Manual verification of the issue completed. Issue is confirmedPriority: P2A defect with this priority could have functionality issues which are not to expectations.A defect with this priority could have functionality issues which are not to expectations.Progress: doneReported on 2.4.xIndicates original Magento version for the Issue report.Indicates original Magento version for the Issue report.Reproduced on 2.4.xThe issue has been reproduced on latest 2.4-develop branchThe issue has been reproduced on latest 2.4-develop branch
Description
This issue is automatically created based on existing pull request: #38628: Minor cleanup: fixed wrong usage of sprintf, it only takes 2 placeholders here and w…
…e gave it 3 arguments.
Description (*)
Found with running phpstan on level 0:
------ ------------------------------------------------------------------------ Line framework-message-queue/Consumer/Config/Validator/ConsumerInstance.php ------ ------------------------------------------------------------------------ 42 Call to sprintf contains 2 placeholders, 3 values given. ------ ------------------------------------------------------------------------
This PR fixes this, it doesn't fix anything major, as the code runs fine as-is and doesn't crash. So this is only a minor cleanup.
I've left the trailing comma, since that's accepted by PHP > 8.0 and it results in cleaner git diffs.
Related Pull Requests
Fixed Issues (if relevant)
Manual testing scenarios (*)
Nothing to test, the code wasn't behaving wrong before, this is just a minor cleanup.
The unit test for this class already tests for the correct exception message, so if unit tests are green, this can be considered good enough.
Questions or comments
Contribution checklist (*)
- Pull request has a meaningful description of its purpose
- All commits are accompanied by meaningful commit messages
- All new or changed code is covered with unit/integration tests (if applicable)
- README.md files for modified modules are updated and included in the pull request if any README.md predefined sections require an update
- All automated tests passed successfully (all builds are green)
Metadata
Metadata
Assignees
Labels
Area: FrameworkComponent: Framework/ComponentIssue: ConfirmedGate 3 Passed. Manual verification of the issue completed. Issue is confirmedGate 3 Passed. Manual verification of the issue completed. Issue is confirmedPriority: P2A defect with this priority could have functionality issues which are not to expectations.A defect with this priority could have functionality issues which are not to expectations.Progress: doneReported on 2.4.xIndicates original Magento version for the Issue report.Indicates original Magento version for the Issue report.Reproduced on 2.4.xThe issue has been reproduced on latest 2.4-develop branchThe issue has been reproduced on latest 2.4-develop branch