Skip to content

Fixed : Meta title issue on product page for Page title suffix #37876

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 7 commits into from
Oct 20, 2023
Merged

Fixed : Meta title issue on product page for Page title suffix #37876

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
3d6eaf4
Meta title issue fixed for product page
Aug 13, 2023
2d39a81
Fixed: Static Tests
Aug 14, 2023
37bac27
Merge branch '2.4-develop' into metatitle-fix
engcom-Hotel Aug 21, 2023
a6c32fa
Merge branch '2.4-develop' into metatitle-fix
engcom-Echo Aug 30, 2023
bd90ae2
Merge branch '2.4-develop' into metatitle-fix
engcom-Echo Sep 4, 2023
ace056a
Automated test coverage added for meta title suffix and prefix
engcom-Echo Sep 5, 2023
aa293cb
Merge branch '2.4-develop' into metatitle-fix
engcom-Lima Sep 6, 2023
File filter

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
21 changes: 20 additions & 1 deletion app/code/Magento/Catalog/Helper/Product/View.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -118,7 +118,8 @@ private function preparePageMetadata(ResultPage $resultPage, $product)
$pageConfig = $resultPage->getConfig();

$metaTitle = $product->getMetaTitle();
$pageConfig->setMetaTitle($metaTitle);
$productMetaTitle = $metaTitle ? $this->addConfigValues($metaTitle) : null;
$pageConfig->setMetaTitle($productMetaTitle);
$pageConfig->getTitle()->set($metaTitle ?: $product->getName());

$keyword = $product->getMetaKeyword();
Expand Down Expand Up @@ -294,4 +295,22 @@ public function prepareAndRender(ResultPage $resultPage, $productId, $controller
$this->preparePageMetadata($resultPage, $product);
return $this;
}

/**
* Add Prefix and Suffix as per the configuration.
*
* @param string $title
* @return string
*/
private function addConfigValues($title)
{
$preparedTitle = $this->scopeConfig->getValue(
'design/head/title_prefix',
\Magento\Store\Model\ScopeInterface::SCOPE_STORE
) . ' ' . $title . ' ' . $this->scopeConfig->getValue(
'design/head/title_suffix',
\Magento\Store\Model\ScopeInterface::SCOPE_STORE
);
return trim($preparedTitle);
}
}
3 changes: 3 additions & 0 deletions dev/tests/integration/testsuite/Magento/Catalog/Helper/Product/ViewTest.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -101,6 +101,8 @@ public function testInitProductLayout()
/**
* @magentoDataFixture Magento/Catalog/_files/multiple_products.php
* @magentoAppIsolation enabled
* @magentoConfigFixture default_store design/head/title_prefix prefix
* @magentoConfigFixture default_store design/head/title_suffix suffix
* @magentoAppArea frontend
*/
public function testPrepareAndRender()
Expand All @@ -112,6 +114,7 @@ public function testPrepareAndRender()
/** @var \Magento\TestFramework\Response $response */
$response = $this->objectManager->get(\Magento\TestFramework\Response::class);
$this->page->renderResult($response);
$this->assertStringContainsString('prefix meta title suffix', $response->getBody());
$this->assertNotEmpty($response->getBody());
$this->assertEquals(
10,
Expand Down