Skip to content

Fixed : Meta title issue on product page for Page title suffix #37876

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 7 commits into from
Oct 20, 2023
Merged

Fixed : Meta title issue on product page for Page title suffix #37876

merged 7 commits into from
Oct 20, 2023

Conversation

aasim110
Copy link
Contributor

@aasim110 aasim110 commented Aug 13, 2023 •
edited
Loading

Page title suffix is included in the "title" tag but not in the "meta title" tag on product pages

Description (*)

Related Pull Requests

Fixed Issues (if relevant)

  1. Fixes Page title suffix is included in "title" tag but not in "meta title" tag in product pages #37680

Manual testing scenarios (*)

  1. Please follow the steps as provided here: Page title suffix is included in "title" tag but not in "meta title" tag in product pages #37680 (comment)

Questions or comments

Contribution checklist (*)

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/integration tests (if applicable)
  • README.md files for modified modules are updated and included in the pull request if any README.md predefined sections require an update
  • All automated tests passed successfully (all builds are green)
@m2-assistant
Copy link

m2-assistant bot commented Aug 13, 2023

Hi @aasim110. Thank you for your contribution!
Here are some useful tips on how you can test your changes using Magento test environment.

Add the comment under your pull request to deploy test or vanilla Magento instance:
  • @magento give me test instance - deploy test instance based on PR changes
  • @magento give me 2.4-develop instance - deploy vanilla Magento instance

❗ Automated tests can be triggered manually with an appropriate comment:

  • @magento run all tests - run or re-run all required tests against the PR changes
  • @magento run <test-build(s)> - run or re-run specific test build(s)
    For example: @magento run Unit Tests

<test-build(s)> is a comma-separated list of build names.

Allowed build names are:
  1. Database Compare
  2. Functional Tests CE
  3. Functional Tests EE
  4. Functional Tests B2B
  5. Integration Tests
  6. Magento Health Index
  7. Sample Data Tests CE
  8. Sample Data Tests EE
  9. Sample Data Tests B2B
  10. Static Tests
  11. Unit Tests
  12. WebAPI Tests
  13. Semantic Version Checker

You can find more information about the builds here
ℹ️ Run only required test builds during development. Run all test builds before sending your pull request for review.

For more details, review the Code Contributions documentation.
Join Magento Community Engineering Slack and ask your questions in #github channel.
@m2-community-project m2-community-project bot added Priority: P3 May be fixed according to the position in the backlog. Progress: pending review labels Aug 13, 2023
@aasim110
Copy link
Contributor Author

@magento run all tests
@magento-automated-testing
Copy link

The requested builds are added to the queue. You should be able to see them here within a few minutes. Please message the #magento-devops slack channel if they don't show in a reasonable amount of time and a representative will look into any issues.
@aasim110
Copy link
Contributor Author

@magento run Static Tests
@magento-automated-testing
Copy link

The requested builds are added to the queue. You should be able to see them here within a few minutes. Please message the #magento-devops slack channel if they don't show in a reasonable amount of time and a representative will look into any issues.
@aasim110
Copy link
Contributor Author

@magento run all Tests
@magento-automated-testing
Copy link

The requested builds are added to the queue. You should be able to see them here within a few minutes. Please message the #magento-devops slack channel if they don't show in a reasonable amount of time and a representative will look into any issues.
@aasim110
Copy link
Contributor Author

@magento run Unit Tests
@magento-automated-testing
Copy link

The requested builds are added to the queue. You should be able to see them here within a few minutes. Please message the #magento-devops slack channel if they don't show in a reasonable amount of time and a representative will look into any issues.
@aasim110
Copy link
Contributor Author

@magento run WebAPI Tests, Unit Tests, Integration Tests
@magento-automated-testing
Copy link

The requested builds are added to the queue. You should be able to see them here within a few minutes. Please message the #magento-devops slack channel if they don't show in a reasonable amount of time and a representative will look into any issues.
@sinhaparul sinhaparul added the Project: Community Picked PRs upvoted by the community label Aug 16, 2023
@aasim110
Copy link
Contributor Author

@magento run Functional Tests CE, Functional Tests EE, Functional Tests B2B
@magento-automated-testing
Copy link

The requested builds are added to the queue. You should be able to see them here within a few minutes. Please message the #magento-devops slack channel if they don't show in a reasonable amount of time and a representative will look into any issues.
@engcom-Hotel
Copy link
Contributor

@magento run all tests
@magento-automated-testing
Copy link

The requested builds are added to the queue. You should be able to see them here within a few minutes. Please message the #magento-devops slack channel if they don't show in a reasonable amount of time and a representative will look into any issues.
@engcom-Hotel engcom-Hotel self-requested a review August 21, 2023 13:24
@aasim110
Copy link
Contributor Author

@magento run Unit Tests, Functional Tests CE, Functional Tests EE
@magento-automated-testing
Copy link

The requested builds are added to the queue. You should be able to see them here within a few minutes. Please message the #magento-devops slack channel if they don't show in a reasonable amount of time and a representative will look into any issues.
@aasim110
Copy link
Contributor Author

@magento run Unit Tests, Functional Tests CE, Functional Tests EE
@magento-automated-testing
Copy link

The requested builds are added to the queue. You should be able to see them here within a few minutes. Please message the #magento-devops slack channel if they don't show in a reasonable amount of time and a representative will look into any issues.
engcom-Hotel
engcom-Hotel requested changes Aug 22, 2023
View reviewed changes
Copy link
Contributor

@engcom-Hotel engcom-Hotel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hello @aasim110,

The code changes look good to me. But I think we can cover these changes with some automated tests like MFTF in accordance with the definition of done.

Thanks
@engcom-Echo
Copy link
Contributor

@magento run all tests
@magento-automated-testing
Copy link

The requested builds are added to the queue. You should be able to see them here within a few minutes. Please message the #magento-devops slack channel if they don't show in a reasonable amount of time and a representative will look into any issues.
@engcom-Echo
Copy link
Contributor

@magento run Integration Tests
@magento-automated-testing
Copy link

The requested builds are added to the queue. You should be able to see them here within a few minutes. Please message the #magento-devops slack channel if they don't show in a reasonable amount of time and a representative will look into any issues.
@engcom-Echo
Copy link
Contributor

@magento run Functional Tests EE,Functional Tests CE,Functional Tests B2B
@magento-automated-testing
Copy link

The requested builds are added to the queue. You should be able to see them here within a few minutes. Please message the #magento-devops slack channel if they don't show in a reasonable amount of time and a representative will look into any issues.
@engcom-Echo
Copy link
Contributor

@magento run Integration Tests
@magento-automated-testing
Copy link

The requested builds are added to the queue. You should be able to see them here within a few minutes. Please message the #magento-devops slack channel if they don't show in a reasonable amount of time and a representative will look into any issues.
@engcom-Echo
Copy link
Contributor

Functional Tests B2B there are no test failures.
Functional Tests CE and Functional Tests EE failure are different on last two run on same commit.
Functional Tests CE
Run1
Screenshot 2023-09-05 at 3 13 55 PM

Run2
Screenshot 2023-09-05 at 3 13 50 PM

Functional Tests EE
Run1
Screenshot 2023-09-05 at 3 13 42 PM

Run2
Screenshot 2023-09-05 at 3 13 38 PM

Moving it to Pending Review as all requested changes are covered.
@engcom-Lima engcom-Lima self-assigned this Sep 5, 2023
@engcom-Lima
Copy link
Contributor

@magento run all tests
@magento-automated-testing
Copy link

The requested builds are added to the queue. You should be able to see them here within a few minutes. Please message the #magento-devops slack channel if they don't show in a reasonable amount of time and a representative will look into any issues.
@engcom-Lima
Copy link
Contributor

✔️ QA Passed

Preconditions:

  • Install fresh Magento 2.4-develop and PHP 8.1

Manual testing scenario:

  1. Go to Content > Design > Configuration > Global settings > HTML Head and add a Page Title Suffix. Please add it as follows in order to make clear what is part of the suffix: | test_suffix
  2. Then inspect the head of a product page that has nothing written in the "meta title" in Search engine optimization. You will see that the meta title will be exactly the same as the title of the page so it should include the suffix
  3. Now edit this product and add the phrase "Custom meta title" in the "meta title" in Search engine optimization
  4. Now inspect again the head of this product page and you will see that the meta title will show "Custom meta title" instead of "Custom meta title | test_suffix" , so the suffix is not added as it should.

Before: ✖️
Screenshot 2023-09-05 at 6 10 41 PM

After: ✔️
Screenshot 2023-09-06 at 11 26 26 AM
Screenshot 2023-09-06 at 11 29 51 AM

Builds are failed. Hence, moving this PR to Extended Testing.
@engcom-Echo
Copy link
Contributor

@magento run Functional Tests CE,WebAPI Tests
@magento-automated-testing
Copy link

The requested builds are added to the queue. You should be able to see them here within a few minutes. Please message the #magento-devops slack channel if they don't show in a reasonable amount of time and a representative will look into any issues.
@engcom-Echo
Copy link
Contributor

Functional Tests CE failure are different on last two run on same commit.
Run1
Screenshot 2023-09-07 at 8 42 04 AM

Run2

Hence moving it to merge in progress
Screenshot 2023-09-07 at 8 42 04 AM
@magento-devops-reposync-svc magento-devops-reposync-svc merged commit 78a1163 into magento:2.4-develop Oct 20, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Priority: P3 May be fixed according to the position in the backlog. Progress: accept Project: Community Picked PRs upvoted by the community
6 participants
@aasim110 @engcom-Hotel @engcom-Echo @engcom-Lima @sinhaparul @magento-devops-reposync-svc