AC-677: Create phpcs static test for ObsoleteMenuTest #288
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
jcuerdo previously approved these changes Sep 29, 2021
m2-community-project bot added Progress: approved and removed Progress: ready for review labels 
eliseacornejo suggested changes Sep 29, 2021
Magento2/ruleset.xml Outdated
| <type>warning</type> | ||
| </rule> | ||
| <rule ref="Magento2.Legacy.ObsoleteMenu"> | ||
| <include-pattern>*\/widget.xml$</include-pattern> |
There was a problem hiding this comment.
This need to be done in widget.xml files? Shouldn't this need to be done in config.xml files?
m2-community-project bot added Progress: changes requested and removed Progress: approved labels 
eliseacornejo previously approved these changes Sep 29, 2021
m2-community-project bot added Progress: approved and removed Progress: changes requested labels eliseacornejo approved these changes Sep 30, 2021
jcuerdo approved these changes Sep 30, 2021
| @magento import pr to magento-commerce/magento-coding-standard |
| @loginesta the Pull Request is successfully imported. |
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
https://jira.corp.magento.com/browse/AC-677 Create phpcs static test for ObsoleteMenuTest