Skip to content

AC-669 install upgrade test #281

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 9 commits into from
Sep 27, 2021
Merged

AC-669 install upgrade test #281

Changes from 1 commit
Commits
Show all changes
9 commits
Select commit Hold shift + click to select a range
08c7084
AC-669: Create phpcs static check for InstallUpgradeTest
svera Sep 23, 2021
38cf408
AC-669: Create phpcs static check for InstallUpgradeTest
svera Sep 23, 2021
b6bff95
AC-669: Create phpcs static check for InstallUpgradeTest
svera Sep 23, 2021
718975a
AC-669: Create phpcs static check for InstallUpgradeTest
svera Sep 23, 2021
230facd
AC-669: Create phpcs static check for InstallUpgradeTest
svera Sep 23, 2021
d47a669
AC-669: Create phpcs static check for InstallUpgradeTest
svera Sep 23, 2021
6601b5b
Merge branch 'develop' into AC-669_InstallUpgradeTest
svera Sep 23, 2021
97b843c
AC-669: Create phpcs static check for InstallUpgradeTest
svera Sep 27, 2021
d974210
AC-669: Create phpcs static check for InstallUpgradeTest
svera Sep 27, 2021
File filter

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
AC-669: Create phpcs static check for InstallUpgradeTest
  • Loading branch information
@svera
svera committed Sep 27, 2021
commit 97b843c9a2a673551c76014c17dd63bc93cd2e47
100 changes: 23 additions & 77 deletions Magento2/Sniffs/Legacy/InstallUpgradeSniff.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,6 +15,25 @@ class InstallUpgradeSniff implements Sniff
{
private const ERROR_CODE = 'obsoleteScript';

private $wrongPrefixes = [
'install-' => 'Install scripts are obsolete. '
. 'Please use declarative schema approach in module\'s etc/db_schema.xml file',
'InstallSchema' => 'InstallSchema scripts are obsolete. '
. 'Please use declarative schema approach in module\'s etc/db_schema.xml file',
'InstallData' => 'InstallData scripts are obsolete. '
. 'Please use data patches approach in module\'s Setup/Patch/Data dir',
'data-install-' => 'Install scripts are obsolete. Please create class InstallData in module\'s Setup folder',
'upgrade-' => 'Upgrade scripts are obsolete. '
. 'Please use declarative schema approach in module\'s etc/db_schema.xml file',
'UpgradeSchema' => 'UpgradeSchema scripts are obsolete. '
. 'Please use declarative schema approach in module\'s etc/db_schema.xml file',
'UpgradeData' => 'UpgradeSchema scripts are obsolete. '
. 'Please use data patches approach in module\'s Setup/Patch/Data dir',
'data-upgrade-' => 'Upgrade scripts are obsolete. '
. 'Please use data patches approach in module\'s Setup/Patch/Data dir',
'recurring' => 'Recurring scripts are obsolete. Please create class Recurring in module\'s Setup folder',
];

/**
* @inheritdoc
*/
Expand All @@ -36,83 +55,10 @@ public function process(File $phpcsFile, $stackPtr)

$fileInfo = new SplFileInfo($phpcsFile->getFilename());

if (strpos($fileInfo->getFilename(), 'install-') === 0) {
$phpcsFile->addError(
'Install scripts are obsolete. '
. 'Please use declarative schema approach in module\'s etc/db_schema.xml file',
0,
self::ERROR_CODE
);
}

if (strpos($fileInfo->getFilename(), 'InstallSchema') === 0) {
$phpcsFile->addError(
'InstallSchema scripts are obsolete. '
. 'Please use declarative schema approach in module\'s etc/db_schema.xml file',
0,
self::ERROR_CODE
);
}

if (strpos($fileInfo->getFilename(), 'InstallData') === 0) {
$phpcsFile->addError(
'InstallData scripts are obsolete. '
. 'Please use data patches approach in module\'s Setup/Patch/Data dir',
0,
self::ERROR_CODE
);
}

if (strpos($fileInfo->getFilename(), 'data-install-') === 0) {
$phpcsFile->addError(
'Install scripts are obsolete. Please create class InstallData in module\'s Setup folder',
0,
self::ERROR_CODE
);
}

if (strpos($fileInfo->getFilename(), 'upgrade-') === 0) {
$phpcsFile->addError(
'Upgrade scripts are obsolete. '
. 'Please use declarative schema approach in module\'s etc/db_schema.xml file',
0,
self::ERROR_CODE
);
}

if (strpos($fileInfo->getFilename(), 'UpgradeSchema') === 0) {
$phpcsFile->addError(
'UpgradeSchema scripts are obsolete. '
. 'Please use declarative schema approach in module\'s etc/db_schema.xml file',
0,
self::ERROR_CODE
);
}

if (strpos($fileInfo->getFilename(), 'UpgradeData') === 0) {
$phpcsFile->addError(
'UpgradeSchema scripts are obsolete. '
. 'Please use data patches approach in module\'s Setup/Patch/Data dir',
0,
self::ERROR_CODE
);
}

if (strpos($fileInfo->getFilename(), 'data-upgrade-') === 0) {
$phpcsFile->addError(
'Upgrade scripts are obsolete. '
. 'Please use data patches approach in module\'s Setup/Patch/Data dir',
0,
self::ERROR_CODE
);
}

if (strpos($fileInfo->getFilename(), 'recurring') === 0) {
$phpcsFile->addError(
'Recurring scripts are obsolete. Please create class Recurring in module\'s Setup folder',
0,
self::ERROR_CODE
);
foreach ($this->wrongPrefixes as $prefix => $errorMessage) {
if (strpos($fileInfo->getFilename(), $prefix) === 0) {
$phpcsFile->addError($errorMessage, 0, self::ERROR_CODE);
}
}

if (preg_match('/(sql|data)/', $fileInfo->getPath()) === 1) {
Expand Down