AC-669 install upgrade test #281
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
loginesta previously approved these changes Sep 23, 2021
m2-community-project bot added Progress: approved and removed Progress: ready for review labels 
jcuerdo suggested changes Sep 23, 2021
| | ||
| $fileInfo = new SplFileInfo($phpcsFile->getFilename()); | ||
| | ||
| if (strpos($fileInfo->getFilename(), 'install-') === 0) { |
There was a problem hiding this comment.
You are doing the same logic with different data several times. Could you extract a method to simplify it?
m2-community-project bot added Progress: changes requested and removed Progress: approved labels | @magento import pr to magento-commerce/magento-coding-standard |
| @svera the Pull Request is successfully imported. |
m2-community-project bot added Progress: done and removed Progress: changes requested labels Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
This sniff checks that no obsolete upgrade files are used, pointing to modern alternatives in that case.